You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "listeng (via GitHub)" <gi...@apache.org> on 2024/03/30 18:23:42 UTC
[PR] fix: corrects some inaccuracies zh translation [superset]
listeng opened a new pull request, #27794:
URL: https://github.com/apache/superset/pull/27794
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR primarily corrects some inaccuracies in the Chinese translation.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
In the welcome page, when there is no data present, the text previously displayed "示例 xxx 将出现在此处" has been corrected to "xxx 将出现在此处". Additionally, some incorrect translations on other pages have also been rectified.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: corrects some inaccuracies zh translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #27794:
URL: https://github.com/apache/superset/pull/27794#discussion_r1550323955
##########
superset/translations/zh/LC_MESSAGES/messages.po:
##########
@@ -20072,3 +20084,9 @@ msgstr "年"
#: superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:578
msgid "zoom area"
msgstr ""
+
+msgid "Profile"
+msgstr "用户资料"
+
+msgid "sign in with"
+msgstr "SSO"
Review Comment:
```suggestion
msgstr "SSO"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: corrects some inaccuracies zh translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27794:
URL: https://github.com/apache/superset/pull/27794#issuecomment-2035408151
Made a couple teensy commits that will hopefully unblock the linters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: corrects some inaccuracies zh translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #27794:
URL: https://github.com/apache/superset/pull/27794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: corrects some inaccuracies zh translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27794:
URL: https://github.com/apache/superset/pull/27794#issuecomment-2032893200
@zhaoyongjie would you be able to make sure the translations are all accurate? Seems fine to me otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: corrects some inaccuracies zh translation [superset]
Posted by "listeng (via GitHub)" <gi...@apache.org>.
listeng commented on PR #27794:
URL: https://github.com/apache/superset/pull/27794#issuecomment-2035067142
> @zhaoyongjie would you be able to make sure the translations are all accurate? Seems fine to me otherwise.
The original translations contained numerous errors that could easily mislead Chinese users. While we have not yet fully translated all entries, but we have corrected the errors and untranslated terms in the webui that relate to functions commonly used by our general user base, as identified through our own usage. We will continue with these work to improve the translations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org