You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2017/12/22 02:10:34 UTC

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms 

Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8910


Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................

IMPALA-5557: Disable rpc_default_keepalive_time_ms

This change makes sure backend connections with KRPC are always
kept alive by disabling the idle connection detection logic.
This disablement was validated with Kudu's rpc-test.

Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
---
M be/src/rpc/rpc-mgr.cc
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/8910/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8910 )

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................

IMPALA-5557: Disable rpc_default_keepalive_time_ms

This change makes sure backend connections with KRPC are always
kept alive by disabling the idle connection detection logic.

Idle connections all tend to be closed and re-opened around the
same time, which may easily lead to negotiation timeouts. Until
KUDU-279 is fixed, closing idle connections is also racy and leads
to query failures.

This disablement was validated with Kudu's rpc-test.

Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Reviewed-on: http://gerrit.cloudera.org:8080/8910
Reviewed-by: Michael Ho <kw...@cloudera.com>
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/rpc/rpc-mgr.cc
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Michael Ho: Looks good to me, but someone else must approve
  Sailesh Mukil: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 )

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

lgtm, had one minor question.

http://gerrit.cloudera.org:8080/#/c/8910/1/be/src/rpc/rpc-mgr.cc
File be/src/rpc/rpc-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/8910/1/be/src/rpc/rpc-mgr.cc@65
PS1, Line 65:   // Disable idle connection detection by setting keepalive_time to -1.
nit: Should we explain in a comment why we do this? If we have plans to re-enable it, should we link to a Jira here?



-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Dec 2017 08:42:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 )

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2018 22:25:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Sailesh Mukil, Joe McDonnell, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8910

to look at the new patch set (#2).

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................

IMPALA-5557: Disable rpc_default_keepalive_time_ms

This change makes sure backend connections with KRPC are always
kept alive by disabling the idle connection detection logic.

Idle connections all tend to be closed and re-opened around the
same time, which may easily lead to negotiation timeouts. Until
KUDU-279 is fixed, closing idle connections is also racy and leads
to query failures.

This disablement was validated with Kudu's rpc-test.

Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
---
M be/src/rpc/rpc-mgr.cc
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/8910/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 )

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1661/


-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2018 18:52:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 )

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8910/1/be/src/rpc/rpc-mgr.cc
File be/src/rpc/rpc-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/8910/1/be/src/rpc/rpc-mgr.cc@65
PS1, Line 65:   // Disable idle connection detection by setting keepalive_time to -1.
> nit: Should we explain in a comment why we do this? If we have plans to re-
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Dec 2017 00:40:17 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 )

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Dec 2017 18:49:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 )

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2018 18:47:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 )

Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0871dd9c9bbe455466b9b2d2a2bbedec79cf0775
Gerrit-Change-Number: 8910
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Dec 2017 00:40:25 +0000
Gerrit-HasComments: No