You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/04/29 17:04:04 UTC
Review Request 33676: Always require slave checkpointing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33676/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-716
https://issues.apache.org/jira/browse/AURORA-716
Repository: aurora
Description
-------
Always require slave checkpointing.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java d0994203b5650f44ca2eb32e1e2aa61875163854
Diff: https://reviews.apache.org/r/33676/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 33676: Always require slave checkpointing.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33676/#review82038
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On April 29, 2015, 8:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33676/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 8:04 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-716
> https://issues.apache.org/jira/browse/AURORA-716
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Always require slave checkpointing.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java d0994203b5650f44ca2eb32e1e2aa61875163854
>
> Diff: https://reviews.apache.org/r/33676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33676: Always require slave checkpointing.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33676/#review81994
-----------------------------------------------------------
The upstream ticket referenced was fixed in 0.22.0 - should we wait until we link against 0.22.0 to ship this patch?
- Kevin Sweeney
On April 29, 2015, 8:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33676/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 8:04 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-716
> https://issues.apache.org/jira/browse/AURORA-716
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Always require slave checkpointing.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java d0994203b5650f44ca2eb32e1e2aa61875163854
>
> Diff: https://reviews.apache.org/r/33676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33676: Always require slave checkpointing.
Posted by Bill Farner <wf...@apache.org>.
> On April 29, 2015, 9:50 p.m., Kevin Sweeney wrote:
> > Actually I may have jumped the gun here - can you verify that mesos will behave sanely when we flip frameworkInfo.checkpoint from false to true (as everyone who has been using the defaults in 0.7.0 will encounter when they attempt to upgrade to 0.8.0)?
I observed sane behavior (at least, a functioning cluster) with the following sequence:
- create a new cluster in vagrant on master
- curl :5051/master/state.json, confirm checkpoint=false
- apply this patch, rebuild/restart scheduler
- curl :5051/master/state.json, observed checkpoint=false (despite sending checkpoint=true)
- end-to-end tests pass
- restart master, checkpoint=true is picked up
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33676/#review82040
-----------------------------------------------------------
On April 29, 2015, 3:04 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33676/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 3:04 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-716
> https://issues.apache.org/jira/browse/AURORA-716
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Always require slave checkpointing.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java d0994203b5650f44ca2eb32e1e2aa61875163854
>
> Diff: https://reviews.apache.org/r/33676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33676: Always require slave checkpointing.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33676/#review82040
-----------------------------------------------------------
Actually I may have jumped the gun here - can you verify that mesos will behave sanely when we flip frameworkInfo.checkpoint from false to true (as everyone who has been using the defaults in 0.7.0 will encounter when they attempt to upgrade to 0.8.0)?
- Kevin Sweeney
On April 29, 2015, 8:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33676/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 8:04 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-716
> https://issues.apache.org/jira/browse/AURORA-716
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Always require slave checkpointing.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java d0994203b5650f44ca2eb32e1e2aa61875163854
>
> Diff: https://reviews.apache.org/r/33676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33676: Always require slave checkpointing.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33676/#review81967
-----------------------------------------------------------
Master (e311dbe) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 29, 2015, 3:04 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33676/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 3:04 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-716
> https://issues.apache.org/jira/browse/AURORA-716
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Always require slave checkpointing.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java d0994203b5650f44ca2eb32e1e2aa61875163854
>
> Diff: https://reviews.apache.org/r/33676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>