You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/29 20:30:26 UTC

[GitHub] [arrow] kou commented on a diff in pull request #35811: GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs

kou commented on code in PR #35811:
URL: https://github.com/apache/arrow/pull/35811#discussion_r1209544729


##########
.github/workflows/dev_pr/link.js:
##########
@@ -83,22 +83,16 @@ async function commentGitHubURL(github, context, pullRequestNumber, issueID) {
   // Make the call to ensure issue exists before adding comment
   const issueInfo = await helpers.getGitHubInfo(github, context, issueID, pullRequestNumber);
   const message = "* Closes: #" + issueInfo.number
-  if (await haveComment(github, context, pullRequestNumber, message)) {
-    return;
-  }
   if (issueInfo){
+    if (context.payload.pull_request.body.includes(message)){

Review Comment:
   ```suggestion
     if (issueInfo) {
       if (context.payload.pull_request.body.includes(message)) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org