You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "masaori335 (via GitHub)" <gi...@apache.org> on 2026/10/02 06:45:21 UTC
[PR] cache: drop CacheTest.cc and RegressionSM from traffic_server [trafficserver]
masaori335 opened a new pull request, #13786:
URL: https://github.com/apache/trafficserver/pull/13786
The level-gated cache tests now run under ctest. The remaining cache op-sequence test is removed rather than ported: its data checks never took effect, its live path is covered by SDK_API_TSCache, and the rest exercised APIs with no callers (non-HTTP lookup, do_io_pread).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cache: drop CacheTest.cc and RegressionSM from traffic_server [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 merged PR #13786:
URL: https://github.com/apache/trafficserver/pull/13786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cache: drop CacheTest.cc and RegressionSM from traffic_server [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on code in PR #13786:
URL: https://github.com/apache/trafficserver/pull/13786#discussion_r4163549384
##########
src/iocore/cache/CMakeLists.txt:
##########
@@ -41,10 +41,6 @@ add_library(
)
add_library(ts::inkcache ALIAS inkcache)
Review Comment:
Good catch — do_io_pread is reached from HttpTunnel for single-range cache hits. I updated the rationale to say the regression is redundant with range.replay.yaml rather than calling the API unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cache: drop CacheTest.cc and RegressionSM from traffic_server [trafficserver]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13786:
URL: https://github.com/apache/trafficserver/pull/13786#discussion_r4163467587
##########
src/iocore/cache/CMakeLists.txt:
##########
@@ -41,10 +41,6 @@ add_library(
)
add_library(ts::inkcache ALIAS inkcache)
Review Comment:
The removal rationale says `do_io_pread` has no callers, but `HttpTunnel.cc:1267` uses it for nonzero-offset cached range responses, and `tests/gold_tests/headers/replays/range.replay.yaml:116-138` exercises that path. Please describe this regression as redundant with the cached-range integration coverage rather than treating the API as unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org