You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by mhujer <gi...@git.apache.org> on 2014/03/08 22:36:20 UTC
[GitHub] cordova-plugin-file-transfer pull request: Upload progress needs t...
GitHub user mhujer opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/23
Upload progress needs to be fixed for second file
Sent bytes must be reseted before new upload, otherwise "onprogress" event "loaded" value provides sum of uploaded bytes (not just for the current upload, but all of them).
This PR fixes the issue for me, but there is additional work necessary:
- check if this does not break anything
- check if it works for file downloading (I'm not using it myself).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mhujer/cordova-plugin-file-transfer wp8-loaded
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 70463c238aa3668c133cbfe88fe4646b1c46a4a6
Author: Martin Hujer <mh...@gmail.com>
Date: 2014-03-08T21:33:37Z
Upload progress now works also for second file
- Sent bytes must be reseted before new upload, otherwise "onprogress" event "loaded" value provides sum of uploaded bytes (not just for the current upload, but all of them)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cordova-plugin-file-transfer pull request: Upload
progress needs t...
Posted by Michal Mocny <mm...@chromium.org>.
GitHub Integration!! Huzzah!
On Sat, Mar 8, 2014 at 4:36 PM, mhujer <gi...@git.apache.org> wrote:
> GitHub user mhujer opened a pull request:
>
> https://github.com/apache/cordova-plugin-file-transfer/pull/23
>
> Upload progress needs to be fixed for second file
>
> Sent bytes must be reseted before new upload, otherwise "onprogress"
> event "loaded" value provides sum of uploaded bytes (not just for the
> current upload, but all of them).
> This PR fixes the issue for me, but there is additional work necessary:
> - check if this does not break anything
> - check if it works for file downloading (I'm not using it myself).
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/mhujer/cordova-plugin-file-transferwp8-loaded
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cordova-plugin-file-transfer/pull/23.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #23
>
> ----
> commit 70463c238aa3668c133cbfe88fe4646b1c46a4a6
> Author: Martin Hujer <mh...@gmail.com>
> Date: 2014-03-08T21:33:37Z
>
> Upload progress now works also for second file
>
> - Sent bytes must be reseted before new upload, otherwise "onprogress"
> event "loaded" value provides sum of uploaded bytes (not just for the
> current upload, but all of them)
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cordova-plugin-file-transfer pull request: [CB-6202] [WP8] Upload ...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/23#issuecomment-44341688
ping @purplecabbage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file-transfer pull request: [CB-6202] [WP8] Upload ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file-transfer pull request: [CB-6202] [WP8] Upload ...
Posted by mhujer <gi...@git.apache.org>.
Github user mhujer commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/23#issuecomment-43472088
@clelland Any chance of getting this merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---