You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "lukasz-antoniak (via GitHub)" <gi...@apache.org> on 2026/04/02 11:44:10 UTC
[PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
lukasz-antoniak opened a new pull request, #193:
URL: https://github.com/apache/cassandra-analytics/pull/193
Fixes [CASSANALYTICS-147](https://issues.apache.org/jira/browse/CASSANALYTICS-147).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "skoppu22 (via GitHub)" <gi...@apache.org>.
skoppu22 commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3045780149
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
Review Comment:
If both start and end are inclusive, don't we need to modify dataSize = end - start + 1 ? Perhaps we can catch this off by a byte by adding content/length verification below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "skoppu22 (via GitHub)" <gi...@apache.org>.
skoppu22 commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3045870708
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -157,7 +157,7 @@ public void testCDCRebufferBackwardSeek() throws IOException
// Backward seek path has a bug: requests buffer.remaining() + 1 bytes
Review Comment:
Existing bug requests 1 byte extra. Looks like after this change, CdcRandomAccessReader's rebuffer requests 2 bytes extra for backward seek case. Assume offset is 0, buffer remaining is 50, then we will request from 0 to 51, which will be 2 bytes extra. Don't we need to fix this code in CdcRandomAccessReader ?
```
// attempting to read bytes previously read
// in practice we read the Commit Logs sequentially
// but we still need to respect random access reader API, it will just require blocking
int requestLen = buffer.remaining() + 1;
long end = offset + requestLen;
BlockingStreamConsumer streamConsumer = new BlockingStreamConsumer();
source.request(offset, end, streamConsumer);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3027626530
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -92,9 +92,9 @@ public void testCDCRebufferSequentialReading() throws IOException
long position = call.start;
// Deliver data in chunks until request is fulfilled
- while (position < actualEnd)
+ while (position <= actualEnd) // range boundaries are inclusive
Review Comment:
According to below JavaDoc, ranges should be considered inclusive.
```
/**
* Asynchronously request bytes for the SSTable file component in the range start-end, and pass on to the StreamConsumer when available.
* The start-end range is inclusive.
*
* @param start the start of the bytes range
* @param end the end of the bytes range
* @param consumer the StreamConsumer to return the bytes to when the request is complete
*/
void request(long start, long end, StreamConsumer consumer);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3065072974
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/streaming/BufferingInputStream.java:
##########
Review Comment:
> For example, if position is 50, does it mean BufferingInputStream should start reading from the offset 50?
Correct, and `rangeStart = position`.
`bytesRead` and `bytesWritten` should be 51 in this case. Count of bytes written and read is 1-based.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "skoppu22 (via GitHub)" <gi...@apache.org>.
skoppu22 commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3075302576
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -157,7 +157,7 @@ public void testCDCRebufferBackwardSeek() throws IOException
// Backward seek path has a bug: requests buffer.remaining() + 1 bytes
Review Comment:
This comment can be removed as you fixed the problem
`// Backward seek path has a bug: requests buffer.remaining() + 1 bytes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3027611441
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/utils/BufferingInputStreamTests.java:
##########
@@ -289,7 +293,7 @@ public Duration timeout()
};
int bytesToRead = chunkSize * numChunks;
- long skipAhead = size - bytesToRead + 1;
+ long skipAhead = size - bytesToRead;
Review Comment:
I am not sure how effective the change in `BufferingInputStream` would affect `skip()` used during BIG index reading. All integration tests pass though, and I think hereby unit test is just a simulation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "skoppu22 (via GitHub)" <gi...@apache.org>.
skoppu22 commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3045740568
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/streaming/BufferingInputStream.java:
##########
Review Comment:
Is this calculation still correct after this fix? For example, if position is 50, does it mean BufferingInputStream should start reading from the offset 50? If yes, don't we need to set both bytesRead and bytesWritten to 50 in that case? Whereas this code will set both of them to `51`. Is this expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3070887325
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -157,7 +157,7 @@ public void testCDCRebufferBackwardSeek() throws IOException
// Backward seek path has a bug: requests buffer.remaining() + 1 bytes
Review Comment:
@skoppu22, can you re-check after latest changes? From what I have tested, there is no extra offset now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#issuecomment-4233853316
@arjunashok, great catch about `autoClose`. Thank you, issue should be solved now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3083049577
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -92,9 +92,9 @@ public void testCDCRebufferSequentialReading() throws IOException
long position = call.start;
// Deliver data in chunks until request is fulfilled
- while (position < actualEnd)
+ while (position <= actualEnd) // range boundaries are inclusive
Review Comment:
Yes. The range is inclusive. Underlying, it sends an HTTP range request to sidecar to get the range of data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "skoppu22 (via GitHub)" <gi...@apache.org>.
skoppu22 commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3075298563
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -157,7 +157,7 @@ public void testCDCRebufferBackwardSeek() throws IOException
// Backward seek path has a bug: requests buffer.remaining() + 1 bytes
Review Comment:
Looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3027626530
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -92,9 +92,9 @@ public void testCDCRebufferSequentialReading() throws IOException
long position = call.start;
// Deliver data in chunks until request is fulfilled
- while (position < actualEnd)
+ while (position <= actualEnd) // range boundaries are inclusive
Review Comment:
According to below JavaDoc, ranges should be consider inclusive.
```
/**
* Asynchronously request bytes for the SSTable file component in the range start-end, and pass on to the StreamConsumer when available.
* The start-end range is inclusive.
*
* @param start the start of the bytes range
* @param end the end of the bytes range
* @param consumer the StreamConsumer to return the bytes to when the request is complete
*/
void request(long start, long end, StreamConsumer consumer);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3027611441
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/utils/BufferingInputStreamTests.java:
##########
@@ -289,7 +293,7 @@ public Duration timeout()
};
int bytesToRead = chunkSize * numChunks;
- long skipAhead = size - bytesToRead + 1;
+ long skipAhead = size - bytesToRead;
Review Comment:
I am not sure how effective the change in `BufferingInputStream` would affect `skip()` used during BIG index reading. All integration tests pass though and I think this test is just a simulation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "arjunashok (via GitHub)" <gi...@apache.org>.
arjunashok commented on PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#issuecomment-4179854913
Seems like `FileSystemSource.request()` has a workaround (lines 94–99) that was compensating for the old off-by-one in `BufferingInputStream.requestMore()`.
Comment in line 97: "Start-end range is inclusive but on the final request end == length so we need to exclude".
With this fix, end is now at most `source.size() - 1`, and length equals source.size(), so `length <= end` is always false.
As a result -
1. the code always takes the `increment = 1` path, which happens to produce the correct end - start + 1, so no data corruption, but it's confusing dead code.
2. More importantly, `close` is never true, so the autoClose path in the finally block never triggers.
For sequential reads via FileSystemSSTable (non-BTI format, where autoClose = true), the RandomAccessFile handle is never closed after the last chunk, which is a file descriptor leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "skoppu22 (via GitHub)" <gi...@apache.org>.
skoppu22 commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3045936030
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -157,7 +157,7 @@ public void testCDCRebufferBackwardSeek() throws IOException
// Backward seek path has a bug: requests buffer.remaining() + 1 bytes
Review Comment:
Looks like this code was always off by 2, this PR didn't change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "skoppu22 (via GitHub)" <gi...@apache.org>.
skoppu22 commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3075302576
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -157,7 +157,7 @@ public void testCDCRebufferBackwardSeek() throws IOException
// Backward seek path has a bug: requests buffer.remaining() + 1 bytes
Review Comment:
This comment can be removed as you fixed the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak merged PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3085115036
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/streaming/BufferingInputStream.java:
##########
Review Comment:
@skoppu22, I take it back. This was actually a root cause of my issue! I was always considering +1 due to condition:
```
public boolean isFinished()
{
return bytesWritten() >= source.size();
}
```
I got confused with `bytesWritten()` and assumed it returns _position-like_ index which need `+1` adjustment at the beginning. My bad. Of course you and Yifan were right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3085115036
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/streaming/BufferingInputStream.java:
##########
Review Comment:
@skoppu22, I take it back. This was actually a root cause of my issue! I was always considering +1 due to condition:
```
public boolean isFinished()
{
return bytesWritten() >= source.size();
}
```
I got confused with `bytesWritten()` returning _position-like_ index. My bad, of course you and Yifan were right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-147: BufferingInputStream fails to read last chunk [cassandra-analytics]
Posted by "arjunashok (via GitHub)" <gi...@apache.org>.
arjunashok commented on code in PR #193:
URL: https://github.com/apache/cassandra-analytics/pull/193#discussion_r3029765735
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/utils/BufferingInputStreamTests.java:
##########
@@ -346,6 +350,76 @@ public Duration timeout()
}
}
+ @Test
+ public void testUnalignedEndReading() throws IOException
Review Comment:
Minor: We might want to assert on `returnedBuffers.size() == 2` to catch regressions where extra or missing requests are issued
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org