You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "jt2594838 (via GitHub)" <gi...@apache.org> on 2024/12/27 06:54:51 UTC
[PR] Detect singular frame lengths in TElasticFramedTransport [iotdb]
jt2594838 opened a new pull request, #14570:
URL: https://github.com/apache/iotdb/pull/14570
If someone mistakenly send HTTP requests to the Thrift-RPC port, the error message is now more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Detect singular frame lengths in TElasticFramedTransport [iotdb]
Posted by "CritasWang (via GitHub)" <gi...@apache.org>.
CritasWang merged PR #14570:
URL: https://github.com/apache/iotdb/pull/14570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Detect singular frame lengths in TElasticFramedTransport [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #14570:
URL: https://github.com/apache/iotdb/pull/14570#issuecomment-2563393790
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14570) **Quality Gate failed**
Failed conditions
 [D Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14570) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14570)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Detect singular frame lengths in TElasticFramedTransport [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #14570:
URL: https://github.com/apache/iotdb/pull/14570#issuecomment-2563427418
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/14570?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `66.66667%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 39.42%. Comparing base [(`81a58c0`)](https://app.codecov.io/gh/apache/iotdb/commit/81a58c0e8904c74c939aa41c28d1247f5890eeca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`54869ab`)](https://app.codecov.io/gh/apache/iotdb/commit/54869abca4519ceab8de5be0e4cb528dcb230056?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/14570?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/iotdb/rpc/TElasticFramedTransport.java](https://app.codecov.io/gh/apache/iotdb/pull/14570?src=pr&el=tree&filepath=iotdb-client%2Fservice-rpc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Frpc%2FTElasticFramedTransport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L3NlcnZpY2UtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9ycGMvVEVsYXN0aWNGcmFtZWRUcmFuc3BvcnQuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #14570 +/- ##
=========================================
Coverage 39.41% 39.42%
Complexity 185 185
=========================================
Files 4341 4341
Lines 275377 275376 -1
Branches 33637 33638 +1
=========================================
+ Hits 108542 108557 +15
+ Misses 166835 166819 -16
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/14570?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org