Re: [PR] [SPARK-48549][SQL] Improve SQL function `sentences` [spark]

["panbingkun (via GitHub)" <gi...@apache.org>]

panbingkun commented on code in PR #46880:
URL: https://github.com/apache/spark/pull/46880#discussion_r1740556642


##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -4263,6 +4263,14 @@ object functions {
   def sentences(string: Column, language: Column, country: Column): Column =
     Column.fn("sentences", string, language, country)
 
+  /**
+   * Splits a string into arrays of sentences, where each sentence is an array of words.
+   * @group string_funcs
+   * @since 4.0.0
+   */
+  def sentences(string: Column, language: Column): Column =

Review Comment:
   Maybe adding such parameter usage in SQL functions would align the two sides.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org