You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/10/04 09:51:05 UTC

[GitHub] [maven-integration-testing] cstamas commented on pull request #116: Fix build consumer tests on OSX

cstamas commented on pull request #116:
URL: https://github.com/apache/maven-integration-testing/pull/116#issuecomment-933323707


   IMHO, if this is needed to _compare_ generated (by test) and expected (checked in git) POMs, then your environment is wrong. Actually, IMHO, the test itself is wrong, by comparing POMs as "string blobs". It would be better to load POMs (both, generated and expected) as List<String> (as line-ending would be omitted then) and just compare the two lists, as this test on Win plaf and on Unix plaf will generate different line-endings, while (depending on your git config) it may not be aligned with checked out POMs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org