You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/01 04:11:46 UTC

[jira] [Commented] (BEAM-1353) Beam should comply with PTransform style guide

    [ https://issues.apache.org/jira/browse/BEAM-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889464#comment-15889464 ] 

ASF GitHub Bot commented on BEAM-1353:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1943


> Beam should comply with PTransform style guide
> ----------------------------------------------
>
>                 Key: BEAM-1353
>                 URL: https://issues.apache.org/jira/browse/BEAM-1353
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core, sdk-java-extensions, sdk-java-gcp, sdk-py
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>              Labels: backward-incompatible
>
> https://beam.apache.org/contribute/ptransform-style-guide/ is a collection of best practices for developing PTransform's.
> Some of these practices shaped up relatively recently, and some Beam transforms violate them, introducing inconsistency into Beam APIs and tempting new library writers and users into mimicking code that's best not mimicked.
> This is an umbrella bug for cleanups bringing individual Beam transforms in accordance with the style guide.
> Please file 1 bug per transform that needs to be fixed (e.g. "Bring KafkaIO in accordance with style guide"); in the bug, describe which aspects need to be fixed (e.g. "should use AutoValue; should explicitly specify type parameters; should not use Coders for serialization") and link it with the current bug.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)