[GitHub] [incubator-liminal] naturalett commented on a change in pull request #46: [LIMINAL-75] add healthcheck ml demo app

[GitBox <gi...@apache.org>]

naturalett commented on a change in pull request #46:
URL: https://github.com/apache/incubator-liminal/pull/46#discussion_r652421653



##########
File path: examples/aws-ml-app-demo/liminal.yml
##########
@@ -1,22 +1,30 @@
 ---
 name: MyDataScienceApp
 owner: Bosco Albert Baracus
+volumes:
+  - volume: gettingstartedvol
+    claim_name: gettingstartedvol-pvc
+    local:
+      path: .
 images:
   - image: myorg/mydatascienceapp
     type: python
-    source: .
 services:
   - service:
     name: my_datascience_server
     type: python_server
     description: my ds server
     image: myorg/mydatascienceapp
+    source: .
     endpoints:
       - endpoint: /predict
         module: serving
         function: predict
+      - endpoint: /healthcheck
+        module: serving
+        function: healthcheck
 pipelines:
-  - pipeline: my_datascience_pipeline
+  - pipeline: my_datascience_server

Review comment:
       my bad




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org