You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2024/05/08 20:54:22 UTC
(pulsar) branch master updated: [improve][broker] Remove unused method CompactionRecord.reset (#22670)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new ad75e3f0921 [improve][broker] Remove unused method CompactionRecord.reset (#22670)
ad75e3f0921 is described below
commit ad75e3f0921bb735766d5e699baea0fc39ac4d41
Author: Dragos Misca <dr...@users.noreply.github.com>
AuthorDate: Wed May 8 13:54:16 2024 -0700
[improve][broker] Remove unused method CompactionRecord.reset (#22670)
---
.../main/java/org/apache/pulsar/compaction/CompactionRecord.java | 8 --------
.../java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java | 4 ----
.../org/apache/pulsar/compaction/CompactorMXBeanImplTest.java | 5 -----
3 files changed, 17 deletions(-)
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java
index 1d2af6638c3..cea005d51b8 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java
@@ -51,14 +51,6 @@ public class CompactionRecord {
public final Rate writeRate = new Rate();
public final Rate readRate = new Rate();
- public void reset() {
- compactionRemovedEventCount.reset();
- compactionSucceedCount.reset();
- compactionFailedCount.reset();
- compactionDurationTimeInMills.reset();
- writeLatencyStats.reset();
- }
-
public void addCompactionRemovedEvent() {
lastCompactionRemovedEventCountOp.increment();
compactionRemovedEventCount.increment();
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java
index 64b91d17d25..8a9d266b56e 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java
@@ -53,10 +53,6 @@ public class CompactorMXBeanImpl implements CompactorMXBean {
return compactionRecordOps.keySet();
}
- public void reset() {
- compactionRecordOps.values().forEach(CompactionRecord::reset);
- }
-
public void addCompactionReadOp(String topic, long readableBytes) {
compactionRecordOps.computeIfAbsent(topic, k -> new CompactionRecord()).addCompactionReadOp(readableBytes);
}
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java
index bbde59d7da8..73e7430bd2d 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java
@@ -59,11 +59,6 @@ public class CompactorMXBeanImplTest {
assertTrue(compaction.getCompactionWriteThroughput() > 0L);
mxBean.addCompactionLatencyOp(topic, 10, TimeUnit.NANOSECONDS);
assertTrue(compaction.getCompactionLatencyBuckets()[0] > 0L);
- mxBean.reset();
- assertEquals(compaction.getCompactionRemovedEventCount(), 0, 0);
- assertEquals(compaction.getCompactionSucceedCount(), 0, 0);
- assertEquals(compaction.getCompactionFailedCount(), 0, 0);
- assertEquals(compaction.getCompactionDurationTimeInMills(), 0, 0);
}
}