[GitHub] [iotdb] SteveYurongSu commented on a diff in pull request #6893: modify deserialize function of FunctionExpression and fix tests of String UDF

[GitBox <gi...@apache.org>]

SteveYurongSu commented on code in PR #6893:
URL: https://github.com/apache/iotdb/pull/6893#discussion_r938751686


##########
tsfile/src/main/java/org/apache/iotdb/tsfile/utils/ReadWriteIOUtils.java:
##########
@@ -691,6 +692,22 @@ public static Map<String, String> readMap(ByteBuffer buffer) {
     return map;
   }
 
+  public static LinkedHashMap<String, String> readLinkedHashMap(ByteBuffer buffer) {
+    int length = readInt(buffer);
+    if (length == NO_BYTE_TO_READ) {
+      return null;

Review Comment:
   It's not a good practice to return null here. It may cause NPE.
   
   I knew that there are a lot of `return null` in this file. I think it's time to do refactor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org