[GitHub] [incubator-superset] thibault-ketterer commented on issue #10054: Athena CSV import fail (no TEXT type)

[GitBox <gi...@apache.org>]

thibault-ketterer commented on issue #10054:
URL: https://github.com/apache/incubator-superset/issues/10054#issuecomment-646311616


   well, yeah, as I said previously I read the code and I was asking what would be the better way to fix the issue
   
   I think reimplementing the whole thing would be overkill.
   
   I don't precisely get what the `get_sqla_column_type` function does and if it might be enough to implement only this function for Athena to override the default types and replace TEXT by STRING.
   As it seem to be the case for mssql implementation.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org