You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/06/25 22:34:36 UTC

[GitHub] [jena] namedgraph commented on pull request #765: Make FileManagerImpl constructors public

namedgraph commented on pull request #765:
URL: https://github.com/apache/jena/pull/765#issuecomment-649851286


   @kinow the `PrefixMapper.initFromPath()` code was copied (long time ago) verbatim from `org.apache.jena.util.LocationMapper`:
   https://github.com/afs/jena/blob/master/jena-core/src/main/java/org/apache/jena/util/LocationMapper.java#L148
   
   I can try `FileManager.get()`, and it probably will work. But in general I think the recent Jena's "internalization" has become too extreme.
   E.g. `LocationMapper` is meant to be a pluggable class, with 3rd party implementations. So if Jena's `LocationMapper` implementation uses `FileManagerImpl`, why shouldn't the 3rd party implementations have access to it? The `LocationMapper` is only "lucky" to have `protected` visibility because it's in the same package as the `FileManagerImpl`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org