You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/06 19:07:26 UTC
[GitHub] [airflow] gmsantos opened a new pull request, #24882: Breeze: Improve version check for kubectl
gmsantos opened a new pull request, #24882:
URL: https://github.com/apache/airflow/pull/24882
kubectl 1.24.0 added a warning that broke the version detection.
It leads to redownload kubectl every time we run a breeze-legacy command.
The change in how the version detection works should be backward
compatible with at least kubectl 1.20, see [command reference](https://v1-20.docs.kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#version).
It should benefit other processes because the `_kind.sh` script is used in
breeze-legacy and the CI tests as well.
Before:
<img width="1077" alt="image" src="https://user-images.githubusercontent.com/1991286/177624209-2d5f1460-731c-46b8-a8fa-cb45c8565f62.png">
After:
<img width="750" alt="image" src="https://user-images.githubusercontent.com/1991286/177624262-0102d7fc-dc68-4cf8-852a-74f5d30d2a21.png">
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24882: Breeze: Improve version check for kubectl
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24882:
URL: https://github.com/apache/airflow/pull/24882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org