You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/09 00:55:49 UTC

[GitHub] [incubator-superset] ktmud commented on pull request #10814: fix: ColorSchemeControl should not use CreatableSelect

ktmud commented on pull request #10814:
URL: https://github.com/apache/incubator-superset/pull/10814#issuecomment-689232512


   Found the original commit that added `ColorSchemeControl`: https://github.com/apache/incubator-superset/pull/3295/files 
   
   There doesn't seem to be a reason to use `CreatableSelect`.
   
   @graceguo-supercat @mistercrunch correct me if you could remember why `Creatable` was used instead of `Select`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org