You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Oliver Heger (JIRA)" <ji...@apache.org> on 2008/07/20 22:36:31 UTC
[jira] Commented: (CLI-123) the minimum and maximum constraints on
a group do not take other groups into account
[ https://issues.apache.org/jira/browse/CLI-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615119#action_12615119 ]
Oliver Heger commented on CLI-123:
----------------------------------
Adding the group options to the command line when one of their child options is found probably makes sense. I have a patch, which does exactly this. However, this changes the semantics of some of the methods of the CommandLine interface slightly. Now the test CommandLineTestCase.testGetOptions_Order() is failing.
This raises the question whether groups should be treated as regular options (then this test case has to be adapted) or whether they should be handled in a special way (then some methods specific for groups have to be added to CommandLine). I would prefer the former.
> the minimum and maximum constraints on a group do not take other groups into account
> ------------------------------------------------------------------------------------
>
> Key: CLI-123
> URL: https://issues.apache.org/jira/browse/CLI-123
> Project: Commons CLI
> Issue Type: Bug
> Components: CLI-2.x
> Affects Versions: 2.0
> Reporter: Andrew Shirley
> Priority: Minor
> Fix For: 2.0
>
> Attachments: BugCLI123Test.java
>
>
> If you have a Group A as a child of Group B and you set a minimum or maximum on Group B, the presence or not of Group A will not affect GroupB. This is because Groups are never added to a CommandLine so .hasOption(A) returns false and so it isn't counted. WriteableCommandLine#addOption(Option) should be used to indicate that a Group is present if any of a Groups children is present.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.