You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2016/06/03 00:24:07 UTC
[VOTE] Apache Commons BeanUtils 1.9.3 RC1
Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/beanutils/
(revision 13874)
commons-beanutils-1.9.3-bin.tar.gz
(SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
commons-beanutils-1.9.3-bin.zip
(SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
commons-beanutils-1.9.3-src.tar.gz
(SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
commons-beanutils-1.9.3-src.zip
(SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
These are the artifacts and their hashes:
commons-beanutils-1.9.3-test-sources.jar
(SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
commons-beanutils-1.9.3-sources.jar
(SHA1: 53bae8809672897cb9954669775fb214623c6b89)
commons-beanutils-1.9.3.pom
(SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
commons-beanutils-1.9.3.jar
(SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
commons-beanutils-1.9.3-javadoc.jar
(SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
commons-beanutils-1.9.3-tests.jar
(SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
Details of changes since 1.9.2 are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
The tag is here:
https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
(revision 1745420)
Site:
http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
(some *relative* links are broken - these will be OK once the site
is deployed)
Clirr Report (compared to 1.9.2):
http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
RAT Report:
http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
KEYS:
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now, i.e. sometime after
18:00 PST 5 June 2016
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thanks!
Gary Gregory
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Benedikt Ritter <br...@apache.org>.
Hello Gary,
Gary Gregory <ga...@gmail.com> schrieb am Di., 7. Juni 2016 um
07:31 Uhr:
> On Mon, Jun 6, 2016 at 10:25 PM, Benedikt Ritter <be...@gmail.com>
> wrote:
>
> > Hello Gary,
> >
> > Gary Gregory <ga...@gmail.com> schrieb am Mo., 6. Juni 2016 um
> > 23:34 Uhr:
> >
> > > On Mon, Jun 6, 2016 at 8:53 AM, Benedikt Ritter <br...@apache.org>
> > > wrote:
> > >
> > > > Hello Gary,
> > > >
> > > > unfortunately I have to vote -1 for two reasons:
> > > >
> > > > 1. tag name does not follow tag naming convention, although I brought
> > > this
> > > > up when the tag was created initially. Looking at the other tags, it
> > > should
> > > > be BEANUTILS_1_9_3_RC1
> > > >
> > >
> > > How is that a blocker? As I wrote previously, I followed the directions
> > in
> > > https://commons.apache.org/releases/prepare.html. At some point, we
> just
> > > need to stick to one process for releasing...
> > >
> >
> > The guide says:
> >
> > "Create the RC tag, by copying the tag workspace to SVN as below. The tag
> > name should include the component name, as this makes it easier to
> > distinguish checkouts. Try to follow the existing naming convention so
> the
> > tag names will sort in a reasonable order. For example NET uses
> > NET_M_N_RC1, and LANG has a similar convention. For an example of how
> > *not* to
> > do it, see https://svn.apache.org/repos/asf/commons/proper/io/tags/ The
> IO
> > tags don't sort properly."
>
>
> They key word here is "Try". I did not because that's an extra useless step
> that is only cosmetic. The example in the instructions is what went by. If
> the text read "You MUST" then I would have done that.
>
Then it looks like we have different interpretations of that text passage.
I understood that "try" means "it's optional" for you. That's not my
understanding. I think it should be a requirement that tag names follow the
convention set up by the component. So maybe we should change the text to
make that more explicit.
Regards,
B
>
> Gary
>
>
> >
>
>
> > Also I pointed out that the tag has the wrong name when it was created.
> >
> >
> > >
> > >
> > > >
> > > > 2. Build fails with:
> > > >
> > >
> > > See my reply to Stian. Same as 1.9.2, which does not make it right I
> > know.
> > >
> >
> > I think we should handle this like we handled the licensing problems for
> > CSV. Having it wrong for the last release doesn't justify having it wrong
> > for the next release.
> >
> > Benedikt
> >
> >
> > >
> > > Hm, CONTRIBUTING.md was also missing.
> > >
> > > Gary
> > >
> > > >
> > > > IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175
> > Not
> > > > IndexedPropertyDescriptor expected:<class
> > > > java.beans.IndexedPropertyDescriptor> but was:<class
> > > > java.beans.PropertyDescriptor>
> > > > IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
> > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > > cast
> > > > to java.beans.IndexedPropertyDescriptor
> > > > IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw
> exception
> > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > > cast
> > > > to java.beans.IndexedPropertyDescriptor
> > > > IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
> > > > IndexedPropertyDescriptor expected:<class
> > > > java.beans.IndexedPropertyDescriptor> but was:<class
> > > > java.beans.PropertyDescriptor>
> > > > IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw
> exception
> > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > > cast
> > > > to java.beans.IndexedPropertyDescriptor
> > > > IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw
> > exception
> > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > > cast
> > > > to java.beans.IndexedPropertyDescriptor
> > > > IndexedPropertyTestCase.testListReadMethod:256 Threw exception
> > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > > cast
> > > > to java.beans.IndexedPropertyDescriptor
> > > > IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
> > > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > > cast
> > > > to java.beans.IndexedPropertyDescriptor
> > > > Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
> > > > was:<java.[util.List]>
> > > > Jira422TestCase.testSecondChildBean:42
> expected:<java.[lang.String]>
> > > but
> > > > was:<java.[util.List]>
> > > >
> > > > when running on:
> > > >
> > > > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
> > > > MaxPermSize=128m; support was removed in 8.0
> > > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > > > 2015-11-10T17:41:47+01:00)
> > > > Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> > > > Java version: 1.8.0_65, vendor: Oracle Corporation
> > > > Java home:
> > > > /Library/Java/JavaVirtualMachines/jdk1.8.0_65.jdk/Contents/Home/jre
> > > > Default locale: de_DE, platform encoding: UTF-8
> > > > OS name: "mac os x", version: "10.11.5", arch: "x86_64", family:
> "mac"
> > > >
> > > > Thank you for pushing a new release!
> > > > Benedikt
> > > >
> > > > Gary Gregory <ga...@gmail.com> schrieb am Fr., 3. Juni 2016
> um
> > > > 02:24 Uhr:
> > > >
> > > > > Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
> > > > >
> > > > > https://dist.apache.org/repos/dist/dev/commons/beanutils/
> > > > > (revision 13874)
> > > > >
> > > > > commons-beanutils-1.9.3-bin.tar.gz
> > > > > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> > > > > commons-beanutils-1.9.3-bin.zip
> > > > > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> > > > > commons-beanutils-1.9.3-src.tar.gz
> > > > > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> > > > > commons-beanutils-1.9.3-src.zip
> > > > > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
> > > > >
> > > > > Maven artifacts are here:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
> > > > >
> > > > > These are the artifacts and their hashes:
> > > > >
> > > > > commons-beanutils-1.9.3-test-sources.jar
> > > > > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> > > > > commons-beanutils-1.9.3-sources.jar
> > > > > (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> > > > > commons-beanutils-1.9.3.pom
> > > > > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> > > > > commons-beanutils-1.9.3.jar
> > > > > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> > > > > commons-beanutils-1.9.3-javadoc.jar
> > > > > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> > > > > commons-beanutils-1.9.3-tests.jar
> > > > > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
> > > > >
> > > > > Details of changes since 1.9.2 are in the release notes:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> > > > >
> > > > >
> > > >
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
> > > > >
> > > > >
> > > > > The tag is here:
> > > > >
> > > > >
> > > >
> > >
> >
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> > > > > (revision 1745420)
> > > > >
> > > > > Site:
> > > > > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
> > > > >
> > > > > (some *relative* links are broken - these will be OK once the site
> > > > > is deployed)
> > > > >
> > > > > Clirr Report (compared to 1.9.2):
> > > > >
> > > >
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
> > > > >
> > > > > RAT Report:
> > > > >
> > > >
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
> > > > >
> > > > > KEYS:
> > > > > https://www.apache.org/dist/commons/KEYS
> > > > >
> > > > > Please review the release candidate and vote.
> > > > >
> > > > > This vote will close no sooner than 72 hours from now, i.e.
> sometime
> > > > after
> > > > > 18:00 PST 5 June 2016
> > > > >
> > > > >
> > > > > [ ] +1 Release these artifacts
> > > > > [ ] +0 OK, but...
> > > > > [ ] -0 OK, but really should fix...
> > > > > [ ] -1 I oppose this release because...
> > > > >
> > > > > Thanks!
> > > > > Gary Gregory
> > > > >
> > > > >
> > > > > --
> > > > > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > > > > Java Persistence with Hibernate, Second Edition
> > > > > <http://www.manning.com/bauer3/>
> > > > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > > > Spring Batch in Action <http://www.manning.com/templier/>
> > > > > Blog: http://garygregory.wordpress.com
> > > > > Home: http://garygregory.com/
> > > > > Tweet! http://twitter.com/GaryGregory
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > > Java Persistence with Hibernate, Second Edition
> > > <http://www.manning.com/bauer3/>
> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > Spring Batch in Action <http://www.manning.com/templier/>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> > >
> >
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Jun 6, 2016 at 10:25 PM, Benedikt Ritter <be...@gmail.com>
wrote:
> Hello Gary,
>
> Gary Gregory <ga...@gmail.com> schrieb am Mo., 6. Juni 2016 um
> 23:34 Uhr:
>
> > On Mon, Jun 6, 2016 at 8:53 AM, Benedikt Ritter <br...@apache.org>
> > wrote:
> >
> > > Hello Gary,
> > >
> > > unfortunately I have to vote -1 for two reasons:
> > >
> > > 1. tag name does not follow tag naming convention, although I brought
> > this
> > > up when the tag was created initially. Looking at the other tags, it
> > should
> > > be BEANUTILS_1_9_3_RC1
> > >
> >
> > How is that a blocker? As I wrote previously, I followed the directions
> in
> > https://commons.apache.org/releases/prepare.html. At some point, we just
> > need to stick to one process for releasing...
> >
>
> The guide says:
>
> "Create the RC tag, by copying the tag workspace to SVN as below. The tag
> name should include the component name, as this makes it easier to
> distinguish checkouts. Try to follow the existing naming convention so the
> tag names will sort in a reasonable order. For example NET uses
> NET_M_N_RC1, and LANG has a similar convention. For an example of how
> *not* to
> do it, see https://svn.apache.org/repos/asf/commons/proper/io/tags/ The IO
> tags don't sort properly."
They key word here is "Try". I did not because that's an extra useless step
that is only cosmetic. The example in the instructions is what went by. If
the text read "You MUST" then I would have done that.
Gary
>
> Also I pointed out that the tag has the wrong name when it was created.
>
>
> >
> >
> > >
> > > 2. Build fails with:
> > >
> >
> > See my reply to Stian. Same as 1.9.2, which does not make it right I
> know.
> >
>
> I think we should handle this like we handled the licensing problems for
> CSV. Having it wrong for the last release doesn't justify having it wrong
> for the next release.
>
> Benedikt
>
>
> >
> > Hm, CONTRIBUTING.md was also missing.
> >
> > Gary
> >
> > >
> > > IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175
> Not
> > > IndexedPropertyDescriptor expected:<class
> > > java.beans.IndexedPropertyDescriptor> but was:<class
> > > java.beans.PropertyDescriptor>
> > > IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
> > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast
> > > to java.beans.IndexedPropertyDescriptor
> > > IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
> > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast
> > > to java.beans.IndexedPropertyDescriptor
> > > IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
> > > IndexedPropertyDescriptor expected:<class
> > > java.beans.IndexedPropertyDescriptor> but was:<class
> > > java.beans.PropertyDescriptor>
> > > IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw exception
> > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast
> > > to java.beans.IndexedPropertyDescriptor
> > > IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw
> exception
> > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast
> > > to java.beans.IndexedPropertyDescriptor
> > > IndexedPropertyTestCase.testListReadMethod:256 Threw exception
> > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast
> > > to java.beans.IndexedPropertyDescriptor
> > > IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
> > > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast
> > > to java.beans.IndexedPropertyDescriptor
> > > Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
> > > was:<java.[util.List]>
> > > Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]>
> > but
> > > was:<java.[util.List]>
> > >
> > > when running on:
> > >
> > > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
> > > MaxPermSize=128m; support was removed in 8.0
> > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > > 2015-11-10T17:41:47+01:00)
> > > Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> > > Java version: 1.8.0_65, vendor: Oracle Corporation
> > > Java home:
> > > /Library/Java/JavaVirtualMachines/jdk1.8.0_65.jdk/Contents/Home/jre
> > > Default locale: de_DE, platform encoding: UTF-8
> > > OS name: "mac os x", version: "10.11.5", arch: "x86_64", family: "mac"
> > >
> > > Thank you for pushing a new release!
> > > Benedikt
> > >
> > > Gary Gregory <ga...@gmail.com> schrieb am Fr., 3. Juni 2016 um
> > > 02:24 Uhr:
> > >
> > > > Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
> > > >
> > > > https://dist.apache.org/repos/dist/dev/commons/beanutils/
> > > > (revision 13874)
> > > >
> > > > commons-beanutils-1.9.3-bin.tar.gz
> > > > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> > > > commons-beanutils-1.9.3-bin.zip
> > > > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> > > > commons-beanutils-1.9.3-src.tar.gz
> > > > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> > > > commons-beanutils-1.9.3-src.zip
> > > > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
> > > >
> > > > Maven artifacts are here:
> > > >
> > > >
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
> > > >
> > > > These are the artifacts and their hashes:
> > > >
> > > > commons-beanutils-1.9.3-test-sources.jar
> > > > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> > > > commons-beanutils-1.9.3-sources.jar
> > > > (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> > > > commons-beanutils-1.9.3.pom
> > > > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> > > > commons-beanutils-1.9.3.jar
> > > > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> > > > commons-beanutils-1.9.3-javadoc.jar
> > > > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> > > > commons-beanutils-1.9.3-tests.jar
> > > > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
> > > >
> > > > Details of changes since 1.9.2 are in the release notes:
> > > >
> > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> > > >
> > > >
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
> > > >
> > > >
> > > > The tag is here:
> > > >
> > > >
> > >
> >
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> > > > (revision 1745420)
> > > >
> > > > Site:
> > > > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
> > > >
> > > > (some *relative* links are broken - these will be OK once the site
> > > > is deployed)
> > > >
> > > > Clirr Report (compared to 1.9.2):
> > > >
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
> > > >
> > > > RAT Report:
> > > >
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
> > > >
> > > > KEYS:
> > > > https://www.apache.org/dist/commons/KEYS
> > > >
> > > > Please review the release candidate and vote.
> > > >
> > > > This vote will close no sooner than 72 hours from now, i.e. sometime
> > > after
> > > > 18:00 PST 5 June 2016
> > > >
> > > >
> > > > [ ] +1 Release these artifacts
> > > > [ ] +0 OK, but...
> > > > [ ] -0 OK, but really should fix...
> > > > [ ] -1 I oppose this release because...
> > > >
> > > > Thanks!
> > > > Gary Gregory
> > > >
> > > >
> > > > --
> > > > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > > > Java Persistence with Hibernate, Second Edition
> > > > <http://www.manning.com/bauer3/>
> > > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > > Spring Batch in Action <http://www.manning.com/templier/>
> > > > Blog: http://garygregory.wordpress.com
> > > > Home: http://garygregory.com/
> > > > Tweet! http://twitter.com/GaryGregory
> > > >
> > >
> >
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Benedikt Ritter <be...@gmail.com>.
Hello Gary,
Gary Gregory <ga...@gmail.com> schrieb am Mo., 6. Juni 2016 um
23:34 Uhr:
> On Mon, Jun 6, 2016 at 8:53 AM, Benedikt Ritter <br...@apache.org>
> wrote:
>
> > Hello Gary,
> >
> > unfortunately I have to vote -1 for two reasons:
> >
> > 1. tag name does not follow tag naming convention, although I brought
> this
> > up when the tag was created initially. Looking at the other tags, it
> should
> > be BEANUTILS_1_9_3_RC1
> >
>
> How is that a blocker? As I wrote previously, I followed the directions in
> https://commons.apache.org/releases/prepare.html. At some point, we just
> need to stick to one process for releasing...
>
The guide says:
"Create the RC tag, by copying the tag workspace to SVN as below. The tag
name should include the component name, as this makes it easier to
distinguish checkouts. Try to follow the existing naming convention so the
tag names will sort in a reasonable order. For example NET uses
NET_M_N_RC1, and LANG has a similar convention. For an example of how *not* to
do it, see https://svn.apache.org/repos/asf/commons/proper/io/tags/ The IO
tags don't sort properly."
Also I pointed out that the tag has the wrong name when it was created.
>
>
> >
> > 2. Build fails with:
> >
>
> See my reply to Stian. Same as 1.9.2, which does not make it right I know.
>
I think we should handle this like we handled the licensing problems for
CSV. Having it wrong for the last release doesn't justify having it wrong
for the next release.
Benedikt
>
> Hm, CONTRIBUTING.md was also missing.
>
> Gary
>
> >
> > IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175 Not
> > IndexedPropertyDescriptor expected:<class
> > java.beans.IndexedPropertyDescriptor> but was:<class
> > java.beans.PropertyDescriptor>
> > IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast
> > to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast
> > to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
> > IndexedPropertyDescriptor expected:<class
> > java.beans.IndexedPropertyDescriptor> but was:<class
> > java.beans.PropertyDescriptor>
> > IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast
> > to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast
> > to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testListReadMethod:256 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast
> > to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast
> > to java.beans.IndexedPropertyDescriptor
> > Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
> > was:<java.[util.List]>
> > Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]>
> but
> > was:<java.[util.List]>
> >
> > when running on:
> >
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
> > MaxPermSize=128m; support was removed in 8.0
> > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > 2015-11-10T17:41:47+01:00)
> > Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> > Java version: 1.8.0_65, vendor: Oracle Corporation
> > Java home:
> > /Library/Java/JavaVirtualMachines/jdk1.8.0_65.jdk/Contents/Home/jre
> > Default locale: de_DE, platform encoding: UTF-8
> > OS name: "mac os x", version: "10.11.5", arch: "x86_64", family: "mac"
> >
> > Thank you for pushing a new release!
> > Benedikt
> >
> > Gary Gregory <ga...@gmail.com> schrieb am Fr., 3. Juni 2016 um
> > 02:24 Uhr:
> >
> > > Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/beanutils/
> > > (revision 13874)
> > >
> > > commons-beanutils-1.9.3-bin.tar.gz
> > > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> > > commons-beanutils-1.9.3-bin.zip
> > > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> > > commons-beanutils-1.9.3-src.tar.gz
> > > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> > > commons-beanutils-1.9.3-src.zip
> > > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
> > >
> > > Maven artifacts are here:
> > >
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
> > >
> > > These are the artifacts and their hashes:
> > >
> > > commons-beanutils-1.9.3-test-sources.jar
> > > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> > > commons-beanutils-1.9.3-sources.jar
> > > (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> > > commons-beanutils-1.9.3.pom
> > > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> > > commons-beanutils-1.9.3.jar
> > > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> > > commons-beanutils-1.9.3-javadoc.jar
> > > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> > > commons-beanutils-1.9.3-tests.jar
> > > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
> > >
> > > Details of changes since 1.9.2 are in the release notes:
> > >
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> > >
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
> > >
> > >
> > > The tag is here:
> > >
> > >
> >
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> > > (revision 1745420)
> > >
> > > Site:
> > > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
> > >
> > > (some *relative* links are broken - these will be OK once the site
> > > is deployed)
> > >
> > > Clirr Report (compared to 1.9.2):
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
> > >
> > > RAT Report:
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
> > >
> > > KEYS:
> > > https://www.apache.org/dist/commons/KEYS
> > >
> > > Please review the release candidate and vote.
> > >
> > > This vote will close no sooner than 72 hours from now, i.e. sometime
> > after
> > > 18:00 PST 5 June 2016
> > >
> > >
> > > [ ] +1 Release these artifacts
> > > [ ] +0 OK, but...
> > > [ ] -0 OK, but really should fix...
> > > [ ] -1 I oppose this release because...
> > >
> > > Thanks!
> > > Gary Gregory
> > >
> > >
> > > --
> > > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > > Java Persistence with Hibernate, Second Edition
> > > <http://www.manning.com/bauer3/>
> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > Spring Batch in Action <http://www.manning.com/templier/>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> > >
> >
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Jun 6, 2016 at 8:53 AM, Benedikt Ritter <br...@apache.org> wrote:
> Hello Gary,
>
> unfortunately I have to vote -1 for two reasons:
>
> 1. tag name does not follow tag naming convention, although I brought this
> up when the tag was created initially. Looking at the other tags, it should
> be BEANUTILS_1_9_3_RC1
>
How is that a blocker? As I wrote previously, I followed the directions in
https://commons.apache.org/releases/prepare.html. At some point, we just
need to stick to one process for releasing...
>
> 2. Build fails with:
>
See my reply to Stian. Same as 1.9.2, which does not make it right I know.
Hm, CONTRIBUTING.md was also missing.
Gary
>
> IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175 Not
> IndexedPropertyDescriptor expected:<class
> java.beans.IndexedPropertyDescriptor> but was:<class
> java.beans.PropertyDescriptor>
> IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
> to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
> to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
> IndexedPropertyDescriptor expected:<class
> java.beans.IndexedPropertyDescriptor> but was:<class
> java.beans.PropertyDescriptor>
> IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
> to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
> to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListReadMethod:256 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
> to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
> to java.beans.IndexedPropertyDescriptor
> Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
> was:<java.[util.List]>
> Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]> but
> was:<java.[util.List]>
>
> when running on:
>
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
> MaxPermSize=128m; support was removed in 8.0
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T17:41:47+01:00)
> Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> Java version: 1.8.0_65, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_65.jdk/Contents/Home/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.5", arch: "x86_64", family: "mac"
>
> Thank you for pushing a new release!
> Benedikt
>
> Gary Gregory <ga...@gmail.com> schrieb am Fr., 3. Juni 2016 um
> 02:24 Uhr:
>
> > Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
> >
> > https://dist.apache.org/repos/dist/dev/commons/beanutils/
> > (revision 13874)
> >
> > commons-beanutils-1.9.3-bin.tar.gz
> > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> > commons-beanutils-1.9.3-bin.zip
> > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> > commons-beanutils-1.9.3-src.tar.gz
> > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> > commons-beanutils-1.9.3-src.zip
> > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
> >
> > Maven artifacts are here:
> >
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
> >
> > These are the artifacts and their hashes:
> >
> > commons-beanutils-1.9.3-test-sources.jar
> > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> > commons-beanutils-1.9.3-sources.jar
> > (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> > commons-beanutils-1.9.3.pom
> > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> > commons-beanutils-1.9.3.jar
> > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> > commons-beanutils-1.9.3-javadoc.jar
> > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> > commons-beanutils-1.9.3-tests.jar
> > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
> >
> > Details of changes since 1.9.2 are in the release notes:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
> >
> >
> > The tag is here:
> >
> >
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> > (revision 1745420)
> >
> > Site:
> > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
> >
> > (some *relative* links are broken - these will be OK once the site
> > is deployed)
> >
> > Clirr Report (compared to 1.9.2):
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
> >
> > RAT Report:
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
> >
> > KEYS:
> > https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> >
> > This vote will close no sooner than 72 hours from now, i.e. sometime
> after
> > 18:00 PST 5 June 2016
> >
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thanks!
> > Gary Gregory
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Benedikt Ritter <br...@apache.org>.
Hello Gary,
unfortunately I have to vote -1 for two reasons:
1. tag name does not follow tag naming convention, although I brought this
up when the tag was created initially. Looking at the other tags, it should
be BEANUTILS_1_9_3_RC1
2. Build fails with:
IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175 Not
IndexedPropertyDescriptor expected:<class
java.beans.IndexedPropertyDescriptor> but was:<class
java.beans.PropertyDescriptor>
IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
IndexedPropertyDescriptor expected:<class
java.beans.IndexedPropertyDescriptor> but was:<class
java.beans.PropertyDescriptor>
IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListReadMethod:256 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be cast
to java.beans.IndexedPropertyDescriptor
Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
was:<java.[util.List]>
Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]> but
was:<java.[util.List]>
when running on:
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
MaxPermSize=128m; support was removed in 8.0
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.8.0_65, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.8.0_65.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.5", arch: "x86_64", family: "mac"
Thank you for pushing a new release!
Benedikt
Gary Gregory <ga...@gmail.com> schrieb am Fr., 3. Juni 2016 um
02:24 Uhr:
> Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/
> (revision 13874)
>
> commons-beanutils-1.9.3-bin.tar.gz
> (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> commons-beanutils-1.9.3-bin.zip
> (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> commons-beanutils-1.9.3-src.tar.gz
> (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> commons-beanutils-1.9.3-src.zip
> (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
>
> These are the artifacts and their hashes:
>
> commons-beanutils-1.9.3-test-sources.jar
> (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> commons-beanutils-1.9.3-sources.jar
> (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> commons-beanutils-1.9.3.pom
> (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> commons-beanutils-1.9.3.jar
> (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> commons-beanutils-1.9.3-javadoc.jar
> (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> commons-beanutils-1.9.3-tests.jar
> (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
>
> Details of changes since 1.9.2 are in the release notes:
>
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
>
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
>
>
> The tag is here:
>
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> (revision 1745420)
>
> Site:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
>
> (some *relative* links are broken - these will be OK once the site
> is deployed)
>
> Clirr Report (compared to 1.9.2):
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
>
> RAT Report:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
>
> This vote will close no sooner than 72 hours from now, i.e. sometime after
> 18:00 PST 5 June 2016
>
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Gary Gregory
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Gary Gregory <ga...@gmail.com>.
Sebb: Thank you for you review.
On Mon, Jun 6, 2016 at 9:10 AM, sebb <se...@gmail.com> wrote:
> STATUS.html and PROPOSAL.html are missing from the source archive.
>
Crud, same as 1.9.2. Will fix in trunk.
>
> Otherwise hashes and sigs and content agree with SVN.
>
> I get the following test failures with Java8 on MacOSX
>
> Failed tests:
> IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175
> Not IndexedPropertyDescriptor expected:<class
> java.beans.IndexedPropertyDescriptor> but was:<class
> java.beans.PropertyDescriptor>
> IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
> IndexedPropertyDescriptor expected:<class
> java.beans.IndexedPropertyDescriptor> but was:<class
> java.beans.PropertyDescriptor>
> IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw
> exception java.lang.ClassCastException: java.beans.PropertyDescriptor
> cannot be cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw
> exception java.lang.ClassCastException: java.beans.PropertyDescriptor
> cannot be cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListReadMethod:256 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
> Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
> was:<java.[util.List]>
> Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]>
> but was:<java.[util.List]>
>
> Tests run: 1281, Failures: 10, Errors: 0, Skipped: 0
>
> I think this needs a -1
>
Same as 1.9.2. See my other replies. What to do? Who can dig in?
Gary
>
>
> On 3 June 2016 at 01:24, Gary Gregory <ga...@gmail.com> wrote:
> > Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
> >
> > https://dist.apache.org/repos/dist/dev/commons/beanutils/
> > (revision 13874)
> >
> > commons-beanutils-1.9.3-bin.tar.gz
> > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> > commons-beanutils-1.9.3-bin.zip
> > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> > commons-beanutils-1.9.3-src.tar.gz
> > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> > commons-beanutils-1.9.3-src.zip
> > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
> >
> > Maven artifacts are here:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
> >
> > These are the artifacts and their hashes:
> >
> > commons-beanutils-1.9.3-test-sources.jar
> > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> > commons-beanutils-1.9.3-sources.jar
> > (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> > commons-beanutils-1.9.3.pom
> > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> > commons-beanutils-1.9.3.jar
> > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> > commons-beanutils-1.9.3-javadoc.jar
> > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> > commons-beanutils-1.9.3-tests.jar
> > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
> >
> > Details of changes since 1.9.2 are in the release notes:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
> >
> >
> > The tag is here:
> >
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> > (revision 1745420)
> >
> > Site:
> > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
> >
> > (some *relative* links are broken - these will be OK once the site
> > is deployed)
> >
> > Clirr Report (compared to 1.9.2):
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
> >
> > RAT Report:
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
> >
> > KEYS:
> > https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> >
> > This vote will close no sooner than 72 hours from now, i.e. sometime
> after
> > 18:00 PST 5 June 2016
> >
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thanks!
> > Gary Gregory
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by sebb <se...@gmail.com>.
STATUS.html and PROPOSAL.html are missing from the source archive.
Otherwise hashes and sigs and content agree with SVN.
I get the following test failures with Java8 on MacOSX
Failed tests:
IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175
Not IndexedPropertyDescriptor expected:<class
java.beans.IndexedPropertyDescriptor> but was:<class
java.beans.PropertyDescriptor>
IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
IndexedPropertyDescriptor expected:<class
java.beans.IndexedPropertyDescriptor> but was:<class
java.beans.PropertyDescriptor>
IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw
exception java.lang.ClassCastException: java.beans.PropertyDescriptor
cannot be cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw
exception java.lang.ClassCastException: java.beans.PropertyDescriptor
cannot be cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListReadMethod:256 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
cast to java.beans.IndexedPropertyDescriptor
Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
was:<java.[util.List]>
Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]>
but was:<java.[util.List]>
Tests run: 1281, Failures: 10, Errors: 0, Skipped: 0
I think this needs a -1
On 3 June 2016 at 01:24, Gary Gregory <ga...@gmail.com> wrote:
> Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/
> (revision 13874)
>
> commons-beanutils-1.9.3-bin.tar.gz
> (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> commons-beanutils-1.9.3-bin.zip
> (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> commons-beanutils-1.9.3-src.tar.gz
> (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> commons-beanutils-1.9.3-src.zip
> (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
>
> These are the artifacts and their hashes:
>
> commons-beanutils-1.9.3-test-sources.jar
> (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> commons-beanutils-1.9.3-sources.jar
> (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> commons-beanutils-1.9.3.pom
> (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> commons-beanutils-1.9.3.jar
> (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> commons-beanutils-1.9.3-javadoc.jar
> (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> commons-beanutils-1.9.3-tests.jar
> (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
>
> Details of changes since 1.9.2 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
>
>
> The tag is here:
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> (revision 1745420)
>
> Site:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
>
> (some *relative* links are broken - these will be OK once the site
> is deployed)
>
> Clirr Report (compared to 1.9.2):
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
>
> RAT Report:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
>
> This vote will close no sooner than 72 hours from now, i.e. sometime after
> 18:00 PST 5 June 2016
>
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Gary Gregory
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Stian Soiland-Reyes <st...@apache.org>.
Agree that my other negatives are not blockers, but we really should be
supporting building with Java 1.8 when that is the current version.
I would love to have a quick look; the errors hint it is just a bug in the
test, but I'm a bit stretched right now, so I can't make a firm promise..
On 6 Jun 2016 10:28 p.m., "Gary Gregory" <ga...@gmail.com> wrote:
> On Mon, Jun 6, 2016 at 7:51 AM, Stian Soiland-Reyes <st...@apache.org>
> wrote:
>
> > Thanks for putting this RC together, Gary, a BeanUtils release is most
> > welcome.
> >
> > Unfortunately, my vote: -1 (binding)
> >
> > .. because the build fails in Windows.
> >
> > Checked:
> >
> > +1 signatures
> > +1 sha1 hashes
> > +1 LICENSE, NOTICE
> > +1 RELEASE-NOTES.txt
> > -1 no README
> >
>
> Thank you for your review Stian :-)
>
> Not a blocker IMO but I added a README.md to trunk as generated by 'mvn
> commons:readme-md'.
>
>
> > +1 mvn apache-rat check
> > -1 What is the file build.properties.sample needed for? Do we still do
> > Ant? This needs to be documented in a README.
> >
>
> Yep, we still have Ant builds laying around a lot of Commons component. I
> do not see why this is a blocker though. I am happy to remove all Ant files
> if that is the consensus.
>
>
> > -1 mvn clean install fails
> >
>
> This is no different than version 1.9.2 with Java 8.
>
> Failed tests:
> org.apache.commons.beanutils.bugs.Jira422TestCase#testRootBean
> ComparisonFailure
> org.apache.commons.beanutils.bugs.Jira422TestCase#testSecondChildBean
> ComparisonFailure
> org.apache.commons.beanutils.IndexedPropertyTestCase#testSetListItemA
> AssertionFailedError
>
>
> org.apache.commons.beanutils.IndexedPropertyTestCase#testListIndexedPropertyDescriptor
> AssertionFailedError
>
>
> org.apache.commons.beanutils.IndexedPropertyTestCase#testArrayListIndexedPropertyDescriptor
> AssertionFailedError
> org.apache.commons.beanutils.IndexedPropertyTestCase#testListReadMethod
> AssertionFailedError
> org.apache.commons.beanutils.IndexedPropertyTestCase#testListWriteMethod
> AssertionFailedError
>
>
> org.apache.commons.beanutils.IndexedPropertyTestCase#testListIndexedReadMethod
> AssertionFailedError
>
>
> org.apache.commons.beanutils.IndexedPropertyTestCase#testListIndexedWriteMethod
> AssertionFailedError
>
>
> org.apache.commons.beanutils.IndexedPropertyTestCase#testArrayListReadMethod
> AssertionFailedError
>
>
> org.apache.commons.beanutils.IndexedPropertyTestCase#testArrayListWriteMethod
> AssertionFailedError
>
> Tests run: 1276, Failures: 11, Errors: 0, Skipped: 0
>
> I had not thought to support Java 8 in this maintenance release. I happy do
> to so if someone puts forth a patch. Otherwise, this could be more of a
> 1.10 theme.
>
> Thoughts?
>
> Gary
>
>
> >
> >
> > Failed tests:
> > IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175
> > Not IndexedPropertyDescriptor expected:<class
> > java.beans.IndexedPropertyDescriptor> but was:<class
> > java.beans.PropertyDescriptor>
> > IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
> > IndexedPropertyDescriptor expected:<class
> > java.beans.IndexedPropertyDescriptor> but was:<class
> > java.beans.PropertyDescriptor>
> > IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw
> > exception java.lang.ClassCastException: java.beans.PropertyDescriptor
> > cannot be cast to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw
> > exception java.lang.ClassCastException: java.beans.PropertyDescriptor
> > cannot be cast to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testListReadMethod:256 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast to java.beans.IndexedPropertyDescriptor
> > IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
> > java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> > cast to java.beans.IndexedPropertyDescriptor
> > Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
> > was:<java.[util.List]>
> > Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]>
> > but was:<java.[util.List]>
> >
> >
> > Second build gives same error.
> >
> >
> >
> > Tested with:
> >
> > C:\Users\stain>mvn -v
> > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > 2015-11-10T16:41:47+00:00)
> > Maven home: C:\Program Files\apache-maven-3.3.9\bin\..
> > Java version: 1.8.0_92, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.8.0_92\jre
> > Default locale: en_GB, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"
> >
> > This is Windows 10 Pro Insider Preview 14332.rs1_release.160422-1940 -
> > but I can't see how that could affect the class casting..
> >
> >
> > I see BeanUtils is not listed on
> > https://builds.apache.org/view/Apache%20Commons/ so I'll add it there.
> >
> > On 3 June 2016 at 01:24, Gary Gregory <ga...@gmail.com> wrote:
> > > Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/beanutils/
> > > (revision 13874)
> > >
> > > commons-beanutils-1.9.3-bin.tar.gz
> > > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> > > commons-beanutils-1.9.3-bin.zip
> > > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> > > commons-beanutils-1.9.3-src.tar.gz
> > > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> > > commons-beanutils-1.9.3-src.zip
> > > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
> > >
> > > Maven artifacts are here:
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
> > >
> > > These are the artifacts and their hashes:
> > >
> > > commons-beanutils-1.9.3-test-sources.jar
> > > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> > > commons-beanutils-1.9.3-sources.jar
> > > (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> > > commons-beanutils-1.9.3.pom
> > > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> > > commons-beanutils-1.9.3.jar
> > > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> > > commons-beanutils-1.9.3-javadoc.jar
> > > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> > > commons-beanutils-1.9.3-tests.jar
> > > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
> > >
> > > Details of changes since 1.9.2 are in the release notes:
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
> > >
> > >
> > > The tag is here:
> > >
> >
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> > > (revision 1745420)
> > >
> > > Site:
> > > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
> > >
> > > (some *relative* links are broken - these will be OK once the site
> > > is deployed)
> > >
> > > Clirr Report (compared to 1.9.2):
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
> > >
> > > RAT Report:
> > >
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
> > >
> > > KEYS:
> > > https://www.apache.org/dist/commons/KEYS
> > >
> > > Please review the release candidate and vote.
> > >
> > > This vote will close no sooner than 72 hours from now, i.e. sometime
> > after
> > > 18:00 PST 5 June 2016
> > >
> > >
> > > [ ] +1 Release these artifacts
> > > [ ] +0 OK, but...
> > > [ ] -0 OK, but really should fix...
> > > [ ] -1 I oppose this release because...
> > >
> > > Thanks!
> > > Gary Gregory
> > >
> > >
> > > --
> > > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > > Java Persistence with Hibernate, Second Edition
> > > <http://www.manning.com/bauer3/>
> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > Spring Batch in Action <http://www.manning.com/templier/>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> >
> >
> >
> > --
> > Stian Soiland-Reyes
> > Apache Taverna (incubating), Apache Commons
> > http://orcid.org/0000-0001-9842-9718
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Jun 6, 2016 at 7:51 AM, Stian Soiland-Reyes <st...@apache.org>
wrote:
> Thanks for putting this RC together, Gary, a BeanUtils release is most
> welcome.
>
> Unfortunately, my vote: -1 (binding)
>
> .. because the build fails in Windows.
>
> Checked:
>
> +1 signatures
> +1 sha1 hashes
> +1 LICENSE, NOTICE
> +1 RELEASE-NOTES.txt
> -1 no README
>
Thank you for your review Stian :-)
Not a blocker IMO but I added a README.md to trunk as generated by 'mvn
commons:readme-md'.
> +1 mvn apache-rat check
> -1 What is the file build.properties.sample needed for? Do we still do
> Ant? This needs to be documented in a README.
>
Yep, we still have Ant builds laying around a lot of Commons component. I
do not see why this is a blocker though. I am happy to remove all Ant files
if that is the consensus.
> -1 mvn clean install fails
>
This is no different than version 1.9.2 with Java 8.
Failed tests:
org.apache.commons.beanutils.bugs.Jira422TestCase#testRootBean
ComparisonFailure
org.apache.commons.beanutils.bugs.Jira422TestCase#testSecondChildBean
ComparisonFailure
org.apache.commons.beanutils.IndexedPropertyTestCase#testSetListItemA
AssertionFailedError
org.apache.commons.beanutils.IndexedPropertyTestCase#testListIndexedPropertyDescriptor
AssertionFailedError
org.apache.commons.beanutils.IndexedPropertyTestCase#testArrayListIndexedPropertyDescriptor
AssertionFailedError
org.apache.commons.beanutils.IndexedPropertyTestCase#testListReadMethod
AssertionFailedError
org.apache.commons.beanutils.IndexedPropertyTestCase#testListWriteMethod
AssertionFailedError
org.apache.commons.beanutils.IndexedPropertyTestCase#testListIndexedReadMethod
AssertionFailedError
org.apache.commons.beanutils.IndexedPropertyTestCase#testListIndexedWriteMethod
AssertionFailedError
org.apache.commons.beanutils.IndexedPropertyTestCase#testArrayListReadMethod
AssertionFailedError
org.apache.commons.beanutils.IndexedPropertyTestCase#testArrayListWriteMethod
AssertionFailedError
Tests run: 1276, Failures: 11, Errors: 0, Skipped: 0
I had not thought to support Java 8 in this maintenance release. I happy do
to so if someone puts forth a patch. Otherwise, this could be more of a
1.10 theme.
Thoughts?
Gary
>
>
> Failed tests:
> IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175
> Not IndexedPropertyDescriptor expected:<class
> java.beans.IndexedPropertyDescriptor> but was:<class
> java.beans.PropertyDescriptor>
> IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
> IndexedPropertyDescriptor expected:<class
> java.beans.IndexedPropertyDescriptor> but was:<class
> java.beans.PropertyDescriptor>
> IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw
> exception java.lang.ClassCastException: java.beans.PropertyDescriptor
> cannot be cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw
> exception java.lang.ClassCastException: java.beans.PropertyDescriptor
> cannot be cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListReadMethod:256 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
> IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
> Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
> was:<java.[util.List]>
> Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]>
> but was:<java.[util.List]>
>
>
> Second build gives same error.
>
>
>
> Tested with:
>
> C:\Users\stain>mvn -v
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T16:41:47+00:00)
> Maven home: C:\Program Files\apache-maven-3.3.9\bin\..
> Java version: 1.8.0_92, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_92\jre
> Default locale: en_GB, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"
>
> This is Windows 10 Pro Insider Preview 14332.rs1_release.160422-1940 -
> but I can't see how that could affect the class casting..
>
>
> I see BeanUtils is not listed on
> https://builds.apache.org/view/Apache%20Commons/ so I'll add it there.
>
> On 3 June 2016 at 01:24, Gary Gregory <ga...@gmail.com> wrote:
> > Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
> >
> > https://dist.apache.org/repos/dist/dev/commons/beanutils/
> > (revision 13874)
> >
> > commons-beanutils-1.9.3-bin.tar.gz
> > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> > commons-beanutils-1.9.3-bin.zip
> > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> > commons-beanutils-1.9.3-src.tar.gz
> > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> > commons-beanutils-1.9.3-src.zip
> > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
> >
> > Maven artifacts are here:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
> >
> > These are the artifacts and their hashes:
> >
> > commons-beanutils-1.9.3-test-sources.jar
> > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> > commons-beanutils-1.9.3-sources.jar
> > (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> > commons-beanutils-1.9.3.pom
> > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> > commons-beanutils-1.9.3.jar
> > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> > commons-beanutils-1.9.3-javadoc.jar
> > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> > commons-beanutils-1.9.3-tests.jar
> > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
> >
> > Details of changes since 1.9.2 are in the release notes:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
> >
> >
> > The tag is here:
> >
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> > (revision 1745420)
> >
> > Site:
> > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
> >
> > (some *relative* links are broken - these will be OK once the site
> > is deployed)
> >
> > Clirr Report (compared to 1.9.2):
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
> >
> > RAT Report:
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
> >
> > KEYS:
> > https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> >
> > This vote will close no sooner than 72 hours from now, i.e. sometime
> after
> > 18:00 PST 5 June 2016
> >
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thanks!
> > Gary Gregory
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
>
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating), Apache Commons
> http://orcid.org/0000-0001-9842-9718
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Stian Soiland-Reyes <st...@apache.org>.
On 6 June 2016 at 15:51, Stian Soiland-Reyes <st...@apache.org> wrote:
> .. because the build fails in Windows.
Or with Maven 3.3 and JDK 1.8.
> I see BeanUtils is not listed on
> https://builds.apache.org/view/Apache%20Commons/ so I'll add it there.
Added as
https://builds.apache.org/view/Apache%20Commons/job/Commons%20Beanutils/
and I can reproduce the error with docker image maven:3.3-jdk-8:
https://builds.apache.org/view/Apache%20Commons/job/Commons%20Beanutils%20docker/6/console
and also I get a javadoc error here with 'native' JDK 1.8 selected in Jenkins:
https://builds.apache.org/view/Apache%20Commons/job/Commons%20Beanutils/3/console
I don't trust the second one as there's "too many" JDKs to choose from
in the Jenkins setup (help needed!) - so that's why I added the Docker
one to test specifically.
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Stian Soiland-Reyes <st...@apache.org>.
Thanks for putting this RC together, Gary, a BeanUtils release is most welcome.
Unfortunately, my vote: -1 (binding)
.. because the build fails in Windows.
Checked:
+1 signatures
+1 sha1 hashes
+1 LICENSE, NOTICE
+1 RELEASE-NOTES.txt
-1 no README
+1 mvn apache-rat check
-1 What is the file build.properties.sample needed for? Do we still do
Ant? This needs to be documented in a README.
-1 mvn clean install fails
Failed tests:
IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175
Not IndexedPropertyDescriptor expected:<class
java.beans.IndexedPropertyDescriptor> but was:<class
java.beans.PropertyDescriptor>
IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
IndexedPropertyDescriptor expected:<class
java.beans.IndexedPropertyDescriptor> but was:<class
java.beans.PropertyDescriptor>
IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw
exception java.lang.ClassCastException: java.beans.PropertyDescriptor
cannot be cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw
exception java.lang.ClassCastException: java.beans.PropertyDescriptor
cannot be cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListReadMethod:256 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
cast to java.beans.IndexedPropertyDescriptor
IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
cast to java.beans.IndexedPropertyDescriptor
Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
was:<java.[util.List]>
Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]>
but was:<java.[util.List]>
Second build gives same error.
Tested with:
C:\Users\stain>mvn -v
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: C:\Program Files\apache-maven-3.3.9\bin\..
Java version: 1.8.0_92, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_92\jre
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"
This is Windows 10 Pro Insider Preview 14332.rs1_release.160422-1940 -
but I can't see how that could affect the class casting..
I see BeanUtils is not listed on
https://builds.apache.org/view/Apache%20Commons/ so I'll add it there.
On 3 June 2016 at 01:24, Gary Gregory <ga...@gmail.com> wrote:
> Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/
> (revision 13874)
>
> commons-beanutils-1.9.3-bin.tar.gz
> (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> commons-beanutils-1.9.3-bin.zip
> (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> commons-beanutils-1.9.3-src.tar.gz
> (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> commons-beanutils-1.9.3-src.zip
> (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
>
> These are the artifacts and their hashes:
>
> commons-beanutils-1.9.3-test-sources.jar
> (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> commons-beanutils-1.9.3-sources.jar
> (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> commons-beanutils-1.9.3.pom
> (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> commons-beanutils-1.9.3.jar
> (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> commons-beanutils-1.9.3-javadoc.jar
> (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> commons-beanutils-1.9.3-tests.jar
> (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
>
> Details of changes since 1.9.2 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
>
>
> The tag is here:
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> (revision 1745420)
>
> Site:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
>
> (some *relative* links are broken - these will be OK once the site
> is deployed)
>
> Clirr Report (compared to 1.9.2):
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
>
> RAT Report:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
>
> This vote will close no sooner than 72 hours from now, i.e. sometime after
> 18:00 PST 5 June 2016
>
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Gary Gregory
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Benedikt Ritter <br...@apache.org>.
Hello Gary,
I'll have a look later today.
Benedikt
Gary Gregory <ga...@gmail.com> schrieb am Fr., 3. Juni 2016 um
02:24 Uhr:
> Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/
> (revision 13874)
>
> commons-beanutils-1.9.3-bin.tar.gz
> (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> commons-beanutils-1.9.3-bin.zip
> (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> commons-beanutils-1.9.3-src.tar.gz
> (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> commons-beanutils-1.9.3-src.zip
> (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
>
> These are the artifacts and their hashes:
>
> commons-beanutils-1.9.3-test-sources.jar
> (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> commons-beanutils-1.9.3-sources.jar
> (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> commons-beanutils-1.9.3.pom
> (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> commons-beanutils-1.9.3.jar
> (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> commons-beanutils-1.9.3-javadoc.jar
> (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> commons-beanutils-1.9.3-tests.jar
> (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
>
> Details of changes since 1.9.2 are in the release notes:
>
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
>
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
>
>
> The tag is here:
>
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> (revision 1745420)
>
> Site:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
>
> (some *relative* links are broken - these will be OK once the site
> is deployed)
>
> Clirr Report (compared to 1.9.2):
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
>
> RAT Report:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
>
> This vote will close no sooner than 72 hours from now, i.e. sometime after
> 18:00 PST 5 June 2016
>
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Gary Gregory
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Oliver Heger <ol...@oliver-heger.de>.
Am 03.06.2016 um 22:16 schrieb Gary Gregory:
> On Jun 3, 2016 12:53 PM, "Oliver Heger" <ol...@oliver-heger.de>
> wrote:
>>
>> Build works fine with Java 1.6 on Windows 10. Artifacts and site look
> good.
>>
>> The site cannot be built with Java 8, and the release notes are missing
>> BEANUTILS-477, but this is not blocking.
>>
>> I ran the tests for [configuration] with the new jar and got a single
>> test failure which seems to be caused by the change for BEANUTILS-474.
>> The tests sets a property using the method setIOFactory() and assumes
>> that the property name is iOFactory. However, now the name IOFactory
>> (with capital I) is returned. Is this correct/desired?
>
> Yes, based on the description of the ticket that deals with the cap change
> IIRC, on my phone now, I can check details later but I think this change is
> indeed as desired.
>
> Maybe the test is
>> just wrong, but in the worst case this change could break some
>> configuration files. How should we handle this?
>
> The test should be adjusted IMO.
>
> A more conservative path would be to revert the change and roll a new RC
> based on the desire for 100% behavior compatibility if that is what we want.
I also tend to agree that the test should be adapted. It is very
unlikely that somebody declares an IOFactory in a configuration file.
And most other properties should have uncritical names. So the risk to
break something is pretty low.
Oliver
>
> Gary
>
>>
>> Oliver
>>
>> Am 03.06.2016 um 02:24 schrieb Gary Gregory:
>>> Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
>>>
>>> https://dist.apache.org/repos/dist/dev/commons/beanutils/
>>> (revision 13874)
>>>
>>> commons-beanutils-1.9.3-bin.tar.gz
>>> (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
>>> commons-beanutils-1.9.3-bin.zip
>>> (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
>>> commons-beanutils-1.9.3-src.tar.gz
>>> (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
>>> commons-beanutils-1.9.3-src.zip
>>> (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
>>>
>>> Maven artifacts are here:
>>>
>>>
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
>>>
>>> These are the artifacts and their hashes:
>>>
>>> commons-beanutils-1.9.3-test-sources.jar
>>> (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
>>> commons-beanutils-1.9.3-sources.jar
>>> (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
>>> commons-beanutils-1.9.3.pom
>>> (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
>>> commons-beanutils-1.9.3.jar
>>> (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
>>> commons-beanutils-1.9.3-javadoc.jar
>>> (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
>>> commons-beanutils-1.9.3-tests.jar
>>> (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
>>>
>>> Details of changes since 1.9.2 are in the release notes:
>>>
>>>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
>>>
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
>>>
>>>
>>> The tag is here:
>>>
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
>>> (revision 1745420)
>>>
>>> Site:
>>> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
>>>
>>> (some *relative* links are broken - these will be OK once the site
>>> is deployed)
>>>
>>> Clirr Report (compared to 1.9.2):
>>>
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
>>>
>>> RAT Report:
>>>
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
>>>
>>> KEYS:
>>> https://www.apache.org/dist/commons/KEYS
>>>
>>> Please review the release candidate and vote.
>>>
>>> This vote will close no sooner than 72 hours from now, i.e. sometime
> after
>>> 18:00 PST 5 June 2016
>>>
>>>
>>> [ ] +1 Release these artifacts
>>> [ ] +0 OK, but...
>>> [ ] -0 OK, but really should fix...
>>> [ ] -1 I oppose this release because...
>>>
>>> Thanks!
>>> Gary Gregory
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Gary Gregory <ga...@gmail.com>.
On Jun 3, 2016 12:53 PM, "Oliver Heger" <ol...@oliver-heger.de>
wrote:
>
> Build works fine with Java 1.6 on Windows 10. Artifacts and site look
good.
>
> The site cannot be built with Java 8, and the release notes are missing
> BEANUTILS-477, but this is not blocking.
>
> I ran the tests for [configuration] with the new jar and got a single
> test failure which seems to be caused by the change for BEANUTILS-474.
> The tests sets a property using the method setIOFactory() and assumes
> that the property name is iOFactory. However, now the name IOFactory
> (with capital I) is returned. Is this correct/desired?
Yes, based on the description of the ticket that deals with the cap change
IIRC, on my phone now, I can check details later but I think this change is
indeed as desired.
Maybe the test is
> just wrong, but in the worst case this change could break some
> configuration files. How should we handle this?
The test should be adjusted IMO.
A more conservative path would be to revert the change and roll a new RC
based on the desire for 100% behavior compatibility if that is what we want.
Gary
>
> Oliver
>
> Am 03.06.2016 um 02:24 schrieb Gary Gregory:
> > Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
> >
> > https://dist.apache.org/repos/dist/dev/commons/beanutils/
> > (revision 13874)
> >
> > commons-beanutils-1.9.3-bin.tar.gz
> > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> > commons-beanutils-1.9.3-bin.zip
> > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> > commons-beanutils-1.9.3-src.tar.gz
> > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> > commons-beanutils-1.9.3-src.zip
> > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
> >
> > Maven artifacts are here:
> >
> >
https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
> >
> > These are the artifacts and their hashes:
> >
> > commons-beanutils-1.9.3-test-sources.jar
> > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> > commons-beanutils-1.9.3-sources.jar
> > (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> > commons-beanutils-1.9.3.pom
> > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> > commons-beanutils-1.9.3.jar
> > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> > commons-beanutils-1.9.3-javadoc.jar
> > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> > commons-beanutils-1.9.3-tests.jar
> > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
> >
> > Details of changes since 1.9.2 are in the release notes:
> >
> >
https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> >
http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
> >
> >
> > The tag is here:
> >
https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> > (revision 1745420)
> >
> > Site:
> > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
> >
> > (some *relative* links are broken - these will be OK once the site
> > is deployed)
> >
> > Clirr Report (compared to 1.9.2):
> >
http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
> >
> > RAT Report:
> >
http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
> >
> > KEYS:
> > https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> >
> > This vote will close no sooner than 72 hours from now, i.e. sometime
after
> > 18:00 PST 5 June 2016
> >
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thanks!
> > Gary Gregory
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Posted by Oliver Heger <ol...@oliver-heger.de>.
Build works fine with Java 1.6 on Windows 10. Artifacts and site look good.
The site cannot be built with Java 8, and the release notes are missing
BEANUTILS-477, but this is not blocking.
I ran the tests for [configuration] with the new jar and got a single
test failure which seems to be caused by the change for BEANUTILS-474.
The tests sets a property using the method setIOFactory() and assumes
that the property name is iOFactory. However, now the name IOFactory
(with capital I) is returned. Is this correct/desired? Maybe the test is
just wrong, but in the worst case this change could break some
configuration files. How should we handle this?
Oliver
Am 03.06.2016 um 02:24 schrieb Gary Gregory:
> Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/
> (revision 13874)
>
> commons-beanutils-1.9.3-bin.tar.gz
> (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> commons-beanutils-1.9.3-bin.zip
> (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> commons-beanutils-1.9.3-src.tar.gz
> (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> commons-beanutils-1.9.3-src.zip
> (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
>
> These are the artifacts and their hashes:
>
> commons-beanutils-1.9.3-test-sources.jar
> (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> commons-beanutils-1.9.3-sources.jar
> (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> commons-beanutils-1.9.3.pom
> (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> commons-beanutils-1.9.3.jar
> (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> commons-beanutils-1.9.3-javadoc.jar
> (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> commons-beanutils-1.9.3-tests.jar
> (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
>
> Details of changes since 1.9.2 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
>
>
> The tag is here:
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> (revision 1745420)
>
> Site:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
>
> (some *relative* links are broken - these will be OK once the site
> is deployed)
>
> Clirr Report (compared to 1.9.2):
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
>
> RAT Report:
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
>
> This vote will close no sooner than 72 hours from now, i.e. sometime after
> 18:00 PST 5 June 2016
>
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Gary Gregory
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org