[GitHub] [arrow-rs] tustvold commented on a change in pull request #1021: Simplify parquet arror `RecordReader`

[GitBox <gi...@apache.org>]

tustvold commented on a change in pull request #1021:
URL: https://github.com/apache/arrow-rs/pull/1021#discussion_r768096700



##########
File path: parquet/src/arrow/record_reader.rs
##########
@@ -381,32 +380,26 @@ impl<T: DataType> RecordReader<T> {
         match rep_levels {
             Some(buf) => {
                 let mut records_read = 0;
+                let mut end_of_last_record = self.num_values;
+
+                for current in self.num_values..self.values_written {
+                    if buf[current] == 0 && current != end_of_last_record {

Review comment:
       > what if you haven't finished the current repeated list
   
   I'm not sure I follow, `buf[current] == 0` implies we've reached the end of the list. Perhaps it would be more clear if the second condition were `current != self.num_values`? :thinking: 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org