You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/29 12:06:37 UTC
[GitHub] [shardingsphere] Lucas-307 opened a new pull request #8807: Optimize job progress
Lucas-307 opened a new pull request #8807:
URL: https://github.com/apache/shardingsphere/pull/8807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #8807: Optimize job progress
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #8807:
URL: https://github.com/apache/shardingsphere/pull/8807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #8807: Optimize job progress
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #8807:
URL: https://github.com/apache/shardingsphere/pull/8807#discussion_r549681583
##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/job/task/incremental/IncrementalTaskProgress.java
##########
@@ -17,21 +17,24 @@
package org.apache.shardingsphere.scaling.core.job.task.incremental;
-import org.apache.shardingsphere.scaling.core.job.TaskProgress;
-import org.apache.shardingsphere.scaling.core.job.position.Position;
-
+import lombok.AllArgsConstructor;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.scaling.core.job.TaskProgress;
+import org.apache.shardingsphere.scaling.core.job.position.Position;
/**
* Incremental task progress.
*/
@Getter
@RequiredArgsConstructor
+@AllArgsConstructor
public final class IncrementalTaskProgress implements TaskProgress {
private final String id;
+ private String shardingItem;
Review comment:
final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8807: Optimize job progress
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8807:
URL: https://github.com/apache/shardingsphere/pull/8807#issuecomment-752072803
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8807?src=pr&el=h1) Report
> Merging [#8807](https://codecov.io/gh/apache/shardingsphere/pull/8807?src=pr&el=desc) (17a14ac) into [master](https://codecov.io/gh/apache/shardingsphere/commit/275339f490d457eb444481b59aa6eb5ade3ba7f6?el=desc) (275339f) will **decrease** coverage by `0.53%`.
> The diff coverage is `86.66%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8807?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8807 +/- ##
============================================
- Coverage 70.26% 69.72% -0.54%
Complexity 626 626
============================================
Files 1601 1607 +6
Lines 25562 25786 +224
Branches 4463 4506 +43
============================================
+ Hits 17960 17980 +20
- Misses 6402 6604 +202
- Partials 1200 1202 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8807?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dingsphere/scaling/core/utils/ScalingTaskUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9TY2FsaW5nVGFza1V0aWwuamF2YQ==) | `62.50% <0.00%> (+6.94%)` | `0.00 <0.00> (ø)` | |
| [.../shardingsphere/scaling/web/HttpServerHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWJvb3RzdHJhcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy93ZWIvSHR0cFNlcnZlckhhbmRsZXIuamF2YQ==) | `84.61% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `30.18% <100.00%> (-2.54%)` | `0.00 <0.00> (ø)` | |
| [...ore/service/impl/DistributedScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL2ltcGwvRGlzdHJpYnV0ZWRTY2FsaW5nSm9iU2VydmljZS5qYXZh) | `97.67% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...core/service/impl/StandaloneScalingJobService.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zZXJ2aWNlL2ltcGwvU3RhbmRhbG9uZVNjYWxpbmdKb2JTZXJ2aWNlLmphdmE=) | `80.64% <100.00%> (+1.33%)` | `0.00 <0.00> (ø)` | |
| [...t/query/type/memory/AbstractMemoryQueryResult.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL3Jlc3VsdC9xdWVyeS90eXBlL21lbW9yeS9BYnN0cmFjdE1lbW9yeVF1ZXJ5UmVzdWx0LmphdmE=) | `88.23% <0.00%> (-5.52%)` | `0.00% <0.00%> (ø%)` | |
| [...driver/jdbc/type/stream/JDBCStreamQueryResult.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL3Jlc3VsdC9xdWVyeS9pbXBsL2RyaXZlci9qZGJjL3R5cGUvc3RyZWFtL0pEQkNTdHJlYW1RdWVyeVJlc3VsdC5qYXZh) | `92.30% <0.00%> (-3.70%)` | `0.00% <0.00%> (ø%)` | |
| [...end/text/distsql/rdl/RDLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL1JETEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `78.78% <0.00%> (-1.22%)` | `0.00% <0.00%> (ø%)` | |
| [...gsphere/infra/optimize/context/CalciteContext.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnRleHQvQ2FsY2l0ZUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ere/infra/optimize/execute/CalciteRawExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2V4ZWN1dGUvQ2FsY2l0ZVJhd0V4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [23 more](https://codecov.io/gh/apache/shardingsphere/pull/8807/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8807?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8807?src=pr&el=footer). Last update [275339f...17a14ac](https://codecov.io/gh/apache/shardingsphere/pull/8807?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org