You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "apalapal (via GitHub)" <gi...@apache.org> on 2023/06/07 08:54:05 UTC

[GitHub] [apisix-helm-chart] apalapal commented on pull request #549: fix: config map admin/viewer secret key

apalapal commented on PR #549:
URL: https://github.com/apache/apisix-helm-chart/pull/549#issuecomment-1580233225

   > nice, found the same problem and fixed it as a part of #551
   
   Indeed :-) I wish I had found yours before spending some time troubleshooting it :-) but I guess we were doing it more or less at the same time.
   I would actually cancel this one, because yours not only fixes the problem as also adds new functionality for overriding the keys, but as it's already submitted, I'll leave it to the reviews to comment...
   Great work by the way...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org