You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/23 19:58:55 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #12893: [IR] Use TVM_DEFINE_OBJECT_REF_METHODS macro for Op
Lunderberg opened a new pull request, #12893:
URL: https://github.com/apache/tvm/pull/12893
Previously, the `get()` method wasn't defined, and returned a `RelayExprNode` instead of a `Op::ContainerType*`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12893: [IR] Use TVM_DEFINE_OBJECT_REF_METHODS macro for Op
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12893:
URL: https://github.com/apache/tvm/pull/12893#issuecomment-1256652876
If I had to guess, that would be based more on implementation timing than anything else. The `OpNode` was first defined in September 2018, but the macro wasn't defined until November 2019.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #12893: [IR] Use TVM_DEFINE_OBJECT_REF_METHODS macro for Op
Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #12893:
URL: https://github.com/apache/tvm/pull/12893#issuecomment-1256832600
It should be ready for merge :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao merged pull request #12893: [IR] Use TVM_DEFINE_OBJECT_REF_METHODS macro for Op
Posted by GitBox <gi...@apache.org>.
junrushao merged PR #12893:
URL: https://github.com/apache/tvm/pull/12893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #12893: [IR] Use TVM_DEFINE_OBJECT_REF_METHODS macro for Op
Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #12893:
URL: https://github.com/apache/tvm/pull/12893#issuecomment-1256709256
Ah ancient history!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org