You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/10/18 00:49:07 UTC
Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_
use shell with the nobody user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-1359
https://issues.apache.org/jira/browse/MESOS-1359
Repository: mesos-git
Description
-------
The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
With the command.shell field, the test can run the command directly.
Diffs
-----
src/tests/slave_tests.cpp a1bd1d4
Diff: https://reviews.apache.org/r/26894/diff/
Testing
-------
make check on linux as root
Thanks,
Niklas Nielsen
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Oct. 18, 2014, 2:50 p.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, line 528
> > <https://reviews.apache.org/r/26894/diff/1/?file=724949#file724949line528>
> >
> > Hm.. this doesn't look like the right usage of shell=false (which should use the `arguments` field):
> >
> > https://github.com/apache/mesos/blob/0.20.1/include/mesos/mesos.proto#L238
>
> R.B. Boyer wrote:
> FYI "shell=false" with arguments is broken until this is merged: https://reviews.apache.org/r/26622/
You are right - we need to introduce a helper program then (I can't think of a way to run the `test` program and whoami at the same time without a shell).
So in short, it would be a helper program that does getuid and compares it with the user entry from the argument given: './test-running-user nobody'
Ben, how does that sound?
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review57283
-----------------------------------------------------------
On Oct. 17, 2014, 3:49 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 3:49 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp a1bd1d4
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 18, 2014, 9:50 p.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, line 528
> > <https://reviews.apache.org/r/26894/diff/1/?file=724949#file724949line528>
> >
> > Hm.. this doesn't look like the right usage of shell=false (which should use the `arguments` field):
> >
> > https://github.com/apache/mesos/blob/0.20.1/include/mesos/mesos.proto#L238
>
> R.B. Boyer wrote:
> FYI "shell=false" with arguments is broken until this is merged: https://reviews.apache.org/r/26622/
>
> Niklas Nielsen wrote:
> You are right - we need to introduce a helper program then (I can't think of a way to run the `test` program and whoami at the same time without a shell).
> So in short, it would be a helper program that does getuid and compares it with the user entry from the argument given: './test-running-user nobody'
> Ben, how does that sound?
That would work but does seem unfortunate. What if we just run '/usr/bin/whoami' and inspect the sandbox stdout for 'nobody'? Not sure if there are other tests that do this. Note that we'd probably need os::which or the like to determine where 'whoami' is.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review57283
-----------------------------------------------------------
On Oct. 17, 2014, 10:49 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 10:49 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp a1bd1d4
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Oct. 18, 2014, 2:50 p.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, line 528
> > <https://reviews.apache.org/r/26894/diff/1/?file=724949#file724949line528>
> >
> > Hm.. this doesn't look like the right usage of shell=false (which should use the `arguments` field):
> >
> > https://github.com/apache/mesos/blob/0.20.1/include/mesos/mesos.proto#L238
>
> R.B. Boyer wrote:
> FYI "shell=false" with arguments is broken until this is merged: https://reviews.apache.org/r/26622/
>
> Niklas Nielsen wrote:
> You are right - we need to introduce a helper program then (I can't think of a way to run the `test` program and whoami at the same time without a shell).
> So in short, it would be a helper program that does getuid and compares it with the user entry from the argument given: './test-running-user nobody'
> Ben, how does that sound?
>
> Ben Mahler wrote:
> That would work but does seem unfortunate. What if we just run '/usr/bin/whoami' and inspect the sandbox stdout for 'nobody'? Not sure if there are other tests that do this. Note that we'd probably need os::which or the like to determine where 'whoami' is.
The new patch use a helper program and runs without a shell. Let me know if that works.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review57283
-----------------------------------------------------------
On Nov. 19, 2014, 8:53 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 8:53 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/tests/active_user_test_helper.cpp PRE-CREATION
> src/tests/slave_tests.cpp 4675dac95e7a9964bdf22259b85d6dd0081af708
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user
Posted by "R.B. Boyer" <bo...@nexusvector.net>.
> On Oct. 18, 2014, 4:50 p.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, line 528
> > <https://reviews.apache.org/r/26894/diff/1/?file=724949#file724949line528>
> >
> > Hm.. this doesn't look like the right usage of shell=false (which should use the `arguments` field):
> >
> > https://github.com/apache/mesos/blob/0.20.1/include/mesos/mesos.proto#L238
FYI "shell=false" with arguments is broken until this is merged: https://reviews.apache.org/r/26622/
- R.B.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review57283
-----------------------------------------------------------
On Oct. 17, 2014, 5:49 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 5:49 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp a1bd1d4
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review57283
-----------------------------------------------------------
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/26894/#comment97843>
Hm.. this doesn't look like the right usage of shell=false (which should use the `arguments` field):
https://github.com/apache/mesos/blob/0.20.1/include/mesos/mesos.proto#L238
- Ben Mahler
On Oct. 17, 2014, 10:49 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 10:49 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp a1bd1d4
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review57250
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26894]
All tests passed.
- Mesos ReviewBot
On Oct. 17, 2014, 10:49 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 10:49 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp a1bd1d4
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review62512
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26894]
All tests passed.
- Mesos ReviewBot
On Nov. 21, 2014, 1:55 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 1:55 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/Makefile.am 1d4ba1c8335eb8106cbccf903eaf3d9fdebdcda2
> src/tests/active_user_test_helper.cpp PRE-CREATION
> src/tests/slave_tests.cpp e0482948c99c5c79b9373fbec96cda12156f38ff
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review62506
-----------------------------------------------------------
Ship it!
Could you cleanup the includes before you commit? Ditto for the using clauses, think you can get rid of vector and process now.
- Ben Mahler
On Nov. 21, 2014, 1:55 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 1:55 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/Makefile.am 1d4ba1c8335eb8106cbccf903eaf3d9fdebdcda2
> src/tests/active_user_test_helper.cpp PRE-CREATION
> src/tests/slave_tests.cpp e0482948c99c5c79b9373fbec96cda12156f38ff
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 1:29 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1359
https://issues.apache.org/jira/browse/MESOS-1359
Repository: mesos-git
Description
-------
The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
With the command.shell field, the test can run the command directly.
Diffs (updated)
-----
src/Makefile.am 1d4ba1c8335eb8106cbccf903eaf3d9fdebdcda2
src/tests/active_user_test_helper.cpp PRE-CREATION
src/tests/slave_tests.cpp e0482948c99c5c79b9373fbec96cda12156f38ff
Diff: https://reviews.apache.org/r/26894/diff/
Testing
-------
make check on linux as root
Thanks,
Niklas Nielsen
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/
-----------------------------------------------------------
(Updated Nov. 20, 2014, 5:55 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-1359
https://issues.apache.org/jira/browse/MESOS-1359
Repository: mesos-git
Description
-------
The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
With the command.shell field, the test can run the command directly.
Diffs (updated)
-----
src/Makefile.am 1d4ba1c8335eb8106cbccf903eaf3d9fdebdcda2
src/tests/active_user_test_helper.cpp PRE-CREATION
src/tests/slave_tests.cpp e0482948c99c5c79b9373fbec96cda12156f38ff
Diff: https://reviews.apache.org/r/26894/diff/
Testing
-------
make check on linux as root
Thanks,
Niklas Nielsen
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review62176
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26894]
All tests passed.
- Mesos ReviewBot
On Nov. 19, 2014, 4:53 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 4:53 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/tests/active_user_test_helper.cpp PRE-CREATION
> src/tests/slave_tests.cpp 4675dac95e7a9964bdf22259b85d6dd0081af708
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Nov. 20, 2014, 5:09 p.m., Ben Mahler wrote:
> > src/tests/active_user_test_helper.cpp, lines 31-60
> > <https://reviews.apache.org/r/26894/diff/2/?file=769867#file769867line31>
> >
> > Curious, do we have to do all this Subprocess stuff with 'whoami' or can we just use os::user?
> >
> > ```
> > Result<std::string> user = os::user();
> >
> > if (user.isSome() && user.get() == expected) {
> > return 0;
> > }
> >
> > return 1;
> > ```
> >
> > If not, let's document why whoami is needed!
Jesus - that should work just fine, but got stuck thinking about whoami from the previous attempts. Thanks! :D
> On Nov. 20, 2014, 5:09 p.m., Ben Mahler wrote:
> > src/tests/active_user_test_helper.cpp, line 26
> > <https://reviews.apache.org/r/26894/diff/2/?file=769867#file769867line26>
> >
> > I think you'll just want to use cout and cerr, otherwise you should initialize glog first.
> >
> > Note that we usually print out Usage information without using LOG(...).
Will do.
> On Nov. 20, 2014, 5:09 p.m., Ben Mahler wrote:
> > src/tests/active_user_test_helper.cpp, lines 21-23
> > <https://reviews.apache.org/r/26894/diff/2/?file=769867#file769867line21>
> >
> > How about:
> >
> > // This helper program takes a an expected user.
> > // Returns 0 if the current username equals the expected username.
> > // Returns 1 otherwise.
Done.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review62478
-----------------------------------------------------------
On Nov. 19, 2014, 8:53 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 8:53 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/tests/active_user_test_helper.cpp PRE-CREATION
> src/tests/slave_tests.cpp 4675dac95e7a9964bdf22259b85d6dd0081af708
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review62478
-----------------------------------------------------------
src/tests/active_user_test_helper.cpp
<https://reviews.apache.org/r/26894/#comment104521>
How about:
// This helper program takes a an expected user.
// Returns 0 if the current username equals the expected username.
// Returns 1 otherwise.
src/tests/active_user_test_helper.cpp
<https://reviews.apache.org/r/26894/#comment104518>
I think you'll just want to use cout and cerr, otherwise you should initialize glog first.
Note that we usually print out Usage information without using LOG(...).
src/tests/active_user_test_helper.cpp
<https://reviews.apache.org/r/26894/#comment104519>
newline?
src/tests/active_user_test_helper.cpp
<https://reviews.apache.org/r/26894/#comment104523>
Curious, do we have to do all this Subprocess stuff with 'whoami' or can we just use os::user?
```
Result<std::string> user = os::user();
if (user.isSome() && user.get() == expected) {
return 0;
}
return 1;
```
If not, let's document why whoami is needed!
- Ben Mahler
On Nov. 19, 2014, 4:53 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 4:53 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1359
> https://issues.apache.org/jira/browse/MESOS-1359
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/tests/active_user_test_helper.cpp PRE-CREATION
> src/tests/slave_tests.cpp 4675dac95e7a9964bdf22259b85d6dd0081af708
>
> Diff: https://reviews.apache.org/r/26894/diff/
>
>
> Testing
> -------
>
> make check on linux as root
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to
_not_ use shell with the nobody user.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/
-----------------------------------------------------------
(Updated Nov. 19, 2014, 8:53 a.m.)
Review request for mesos and Ben Mahler.
Summary (updated)
-----------------
Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.
Bugs: MESOS-1359
https://issues.apache.org/jira/browse/MESOS-1359
Repository: mesos-git
Description
-------
The 'nobody' user is restricted on some systems from shell access and broke the task.user tests (which have been disabled since then).
With the command.shell field, the test can run the command directly.
Diffs (updated)
-----
src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
src/tests/active_user_test_helper.cpp PRE-CREATION
src/tests/slave_tests.cpp 4675dac95e7a9964bdf22259b85d6dd0081af708
Diff: https://reviews.apache.org/r/26894/diff/
Testing
-------
make check on linux as root
Thanks,
Niklas Nielsen