You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/10/16 21:31:52 UTC

[GitHub] mrutkows commented on a change in pull request #991: Introducing include and exclude in zip action

mrutkows commented on a change in pull request #991: Introducing include and exclude in zip action
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/991#discussion_r225713712
 
 

 ##########
 File path: parsers/manifest_parser.go
 ##########
 @@ -649,7 +649,7 @@ func (dm *YAMLParser) readActionFunction(manifestFilePath string, manifestFileNa
 
 	if utils.IsDirectory(actionFilePath) {
 		zipFileName = actionFilePath + "." + runtimes.ZIP_FILE_EXTENSION
-		err := utils.NewZipWritter(actionFilePath, zipFileName).Zip()
 
 Review comment:
   is there a reason this is called "Writter" and not 'Writer" ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services