You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2016/07/04 02:28:17 UTC
[Bug 59789] New: Comments not shifted when row shifting
https://bz.apache.org/bugzilla/show_bug.cgi?id=59789
Bug ID: 59789
Summary: Comments not shifted when row shifting
Product: POI
Version: 3.15-dev
Hardware: PC
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: HSSF
Assignee: dev@poi.apache.org
Reporter: onealj@apache.org
Found by Findbugs on POI-JDK8
HSSFSheet.java:1565, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT, Priority: Normal
Return value of org.apache.poi.hssf.model.InternalSheet.getNoteRecords()
ignored, but method has no side effect
if (moveComments) {
_sheet.getNoteRecords()
}
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59789] Improve speed of shifting comments when shifting rows
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59789
Javen O'Neal <on...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Comments not shifted when |Improve speed of shifting
|row shifting |comments when shifting rows
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59789] Comments not shifted when row shifting
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59789
Javen O'Neal <on...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Javen O'Neal <on...@apache.org> ---
HSSFComment shifting was already done inside the main for-loop, but had pretty
terrible performance because it searched the drawing patriarch for all comments
for ever row in the shift range.
Assuming all NoteRecords are HSSFComments, we can move the comment shifting
that's done inside the main for-loop outside so that only one search for
HSSFComments in the drawing patriarch is necessary.
Applied in r1751198.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59789] Improve performance of row shifting on sheets that
contain comments
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59789
Javen O'Neal <on...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Improve speed of shifting |Improve performance of row
|comments when shifting rows |shifting on sheets that
| |contain comments
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org