[jira] [Commented] (HBASE-22250) The same constants used in many places should be placed in constant classes

["HBase QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818507#comment-16818507 ] 

HBase QA commented on HBASE-22250:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} | {color:red} HBASE-22250 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22250 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12966021/HBASE-22250_2.patch |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/95/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> The same constants used in many places should be placed in constant classes
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-22250
>                 URL: https://issues.apache.org/jira/browse/HBASE-22250
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, conf, regionserver
>    Affects Versions: 1.2.0, 2.0.0, 2.1.1, 2.1.4
>            Reporter: lixiaobao
>            Assignee: lixiaobao
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HBASE-22250.patch, HBASE-22250_2.patch
>
>
> I think we should put these configurations in the HConstants class to avoid the trouble of modifying a lot of places when we modify them later.
> {code:java}
> public static final String MASTER_KRB_PRINCIPAL = "hbase.master.kerberos.principal";
> public static final String MASTER_KRB_KEYTAB_FILE = "hbase.master.keytab.file";
> public static final String REGIONSERVER_KRB_PRINCIPAL = "hbase.regionserver.kerberos.principal";
> public static final String REGIONSERVER_KRB_KEYTAB_FILE = "hbase.regionserver.keytab.file";{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)