[GitHub] [iotdb] LebronAl commented on pull request #3086: [IOTDB-1339] optimize TimeoutChangeableTSnappyFramedTransport

[GitBox <gi...@apache.org>]

LebronAl commented on pull request #3086:
URL: https://github.com/apache/iotdb/pull/3086#issuecomment-828359552


   > > LGTM
   > > BTW, how about applying these two parameters to `TimeoutChangeableTFastFramedTransport` and `TimeoutChangeableTSnappyFramedTransport` too?
   > 
   > hi， because TimeoutChangeableTFastFramedTransport do not use two parameter in TimeoutChangeableTFastFramedTransport. There is the same as TimeoutChangeableTSnappyFramedTransport.
   
   It seems that these two parameters were used by `flush()` and `readFrame()` in `TElasticFramedTransport`.
   
   The `underlyingSocket` field in `TimeoutChangeableTFastFramedTransport` and `TimeoutChangeableTSnappyFramedTransport` is just holding a reference of `underlying` to perfrom timeout related logic.
   
   If their parent class supports applying these two parameters, why don't they?
   Just like
   ```Java
     public TimeoutChangeableTFastFramedTransport(TSocket underlying) {
       super(underlying,thriftDefaultBufferSize, thriftMaxFrameSize);
       this.underlyingSocket = underlying;
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org