[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #29026:
URL: https://github.com/apache/spark/pull/29026#discussion_r451246428



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
##########
@@ -288,7 +288,7 @@ public void setDecimal(int ordinal, Decimal value, int precision) {
       Platform.putLong(baseObject, baseOffset + cursor, 0L);
       Platform.putLong(baseObject, baseOffset + cursor + 8, 0L);
 
-      if (value == null) {
+      if (value == null || !value.changePrecision(precision, value.scale())) {

Review comment:
       This looks valid for branch-3.0 and branch-2.4. Do you think we need to backport to to branch-2.4?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org