You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2014/06/12 20:49:04 UTC

Review Request 22520: ACCUMULO-2899 Correctly handle older internals.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22520/
-----------------------------------------------------------

Review request for accumulo and Mike Drob.


Bugs: ACCUMULO-2899
    https://issues.apache.org/jira/browse/ACCUMULO-2899


Repository: accumulo


Description
-------

Make sure that we behave correctly when our cluster has been upgraded 1.4 -> 1.5 -> 1.6

* dfsloggers need to track the cq used to create them so they can be used to issue putDeletes
* rewrite 1.4 WAL paths to the top level wal directory
* adjust recovery path to compensate for 1.4 recovered wals
* fix GC to properly handle upgraded WALs

Author: Mike Drob <md...@cloudera.com>
Author: Sean Busbey <bu...@cloudera.com>


Diffs
-----

  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 5c1194a18456ff998a9d228ae07b52c292114450 
  server/base/src/main/java/org/apache/accumulo/server/master/recovery/RecoveryPath.java 1da945d21640228ac8323239de5dcc59255aa580 
  server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java ae850af1202880ebc770c5136822c9343e46ff36 
  server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogsTest.java f90b965a69975f04db636639a8474dd1f1b8fce1 
  server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java f73d4ca87cbd7307d9f2d08dc8be02c43e40f7f4 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java cca29534396f614962fc4dcf959415e5c40450a7 

Diff: https://reviews.apache.org/r/22520/diff/


Testing
-------

units pass for both hadoop profiles. running -P sunny now.


Thanks,

Sean Busbey


Re: Review Request 22520: ACCUMULO-2899 Correctly handle older internals.

Posted by Mike Drob <md...@mdrob.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22520/#review45521
-----------------------------------------------------------

Ship it!


Ship It!

- Mike Drob


On June 12, 2014, 6:49 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22520/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 6:49 p.m.)
> 
> 
> Review request for accumulo and Mike Drob.
> 
> 
> Bugs: ACCUMULO-2899
>     https://issues.apache.org/jira/browse/ACCUMULO-2899
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Make sure that we behave correctly when our cluster has been upgraded 1.4 -> 1.5 -> 1.6
> 
> * dfsloggers need to track the cq used to create them so they can be used to issue putDeletes
> * rewrite 1.4 WAL paths to the top level wal directory
> * adjust recovery path to compensate for 1.4 recovered wals
> * fix GC to properly handle upgraded WALs
> 
> Author: Mike Drob <md...@cloudera.com>
> Author: Sean Busbey <bu...@cloudera.com>
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 5c1194a18456ff998a9d228ae07b52c292114450 
>   server/base/src/main/java/org/apache/accumulo/server/master/recovery/RecoveryPath.java 1da945d21640228ac8323239de5dcc59255aa580 
>   server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java ae850af1202880ebc770c5136822c9343e46ff36 
>   server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogsTest.java f90b965a69975f04db636639a8474dd1f1b8fce1 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java f73d4ca87cbd7307d9f2d08dc8be02c43e40f7f4 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java cca29534396f614962fc4dcf959415e5c40450a7 
> 
> Diff: https://reviews.apache.org/r/22520/diff/
> 
> 
> Testing
> -------
> 
> units pass for both hadoop profiles. running -P sunny now.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Re: Review Request 22520: ACCUMULO-2899 Correctly handle older internals.

Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22520/
-----------------------------------------------------------

(Updated June 12, 2014, 7:48 p.m.)


Review request for accumulo and Mike Drob.


Bugs: ACCUMULO-2899
    https://issues.apache.org/jira/browse/ACCUMULO-2899


Repository: accumulo


Description
-------

Make sure that we behave correctly when our cluster has been upgraded 1.4 -> 1.5 -> 1.6

* dfsloggers need to track the cq used to create them so they can be used to issue putDeletes
* rewrite 1.4 WAL paths to the top level wal directory
* adjust recovery path to compensate for 1.4 recovered wals
* fix GC to properly handle upgraded WALs

Author: Mike Drob <md...@cloudera.com>
Author: Sean Busbey <bu...@cloudera.com>


Diffs
-----

  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 5c1194a18456ff998a9d228ae07b52c292114450 
  server/base/src/main/java/org/apache/accumulo/server/master/recovery/RecoveryPath.java 1da945d21640228ac8323239de5dcc59255aa580 
  server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java ae850af1202880ebc770c5136822c9343e46ff36 
  server/gc/src/test/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogsTest.java f90b965a69975f04db636639a8474dd1f1b8fce1 
  server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java f73d4ca87cbd7307d9f2d08dc8be02c43e40f7f4 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java cca29534396f614962fc4dcf959415e5c40450a7 

Diff: https://reviews.apache.org/r/22520/diff/


Testing (updated)
-------

units pass for both hadoop profiles. -P sunny passes


Thanks,

Sean Busbey