[jira] [Commented] (CB-8392) Valid Java package names are marked as invalid when trying to add android platform

["Sarangan Rajamanickam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181412#comment-15181412 ] 

Sarangan Rajamanickam commented on CB-8392:
-------------------------------------------

This issue has already been fixed with this commit https://github.com/apache/cordova-android/commit/e4c9bebe34005a9246c8688c63d4079485c4115e#diff-0bb72f2f413d42540a8cba299ac9b278 

> Valid Java package names are marked as invalid when trying to add android platform
> ----------------------------------------------------------------------------------
>
>                 Key: CB-8392
>                 URL: https://issues.apache.org/jira/browse/CB-8392
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>         Environment: cordova-android 3.6.4
>            Reporter: Steve Lam
>            Priority: Minor
>
> cordova-android 3.6.4 is reporting "com._123abc.MyApp" as invalid Java package while allowing "com.123abc.MyApp" which is an actual invalid Java package name (http://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html).
> In bin/lib/create.js, line 150:
> {noformat}
> if (!/^[a-zA-Z]+(\.[a-zA-Z0-9][a-zA-Z0-9_]*)+$/.test(package_name)) {
>     return Q.reject('Package name must look like: com.company.Name');
> }
> {noformat}
> Should be changed to:
> {noformat}
> if (!/^[a-zA-Z]+(\.[a-zA-Z_][a-zA-Z0-9_]*)+$/.test(package_name) ) {
> {noformat}
> Thus allowing for valid Java package names such as:
> com._123abc.MyApp



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org