You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/18 23:42:01 UTC
[GitHub] [mynewt-core] utzig opened a new pull request #2491: Fix Kinetis HASH driver with small length buffers
utzig opened a new pull request #2491:
URL: https://github.com/apache/mynewt-core/pull/2491
* apps: hash_test: add small varlen inputs test - Add a new test that hashes multiple small variable length strings into a digest, where each string is smaller than SHA-256 block length.
* hw: drivers: hash_kinetis: fix small buffer hashing - Hashing a message with multiple blocks of length<=64 (SHA-256 block length) was broken due to proper usage of the mmCAU padding. This commit fixes the handling of the pad data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2491: Fix Kinetis HASH driver with small length buffers
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2491:
URL: https://github.com/apache/mynewt-core/pull/2491#issuecomment-781708644
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/hash/hash_kinetis/src/hash_kinetis.c
<details>
```diff
@@ -72,7 +72,7 @@
static int
kinetis_hash_update(struct hash_dev *hash, void *ctx, uint16_t algo,
- const void *inbuf, uint32_t inlen)
+ const void *inbuf, uint32_t inlen)
{
uint32_t i;
uint32_t remain;
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2491: Fix Kinetis HASH driver with small length buffers
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2491:
URL: https://github.com/apache/mynewt-core/pull/2491#issuecomment-781709724
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2491: Fix Kinetis HASH driver with small length buffers
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2491:
URL: https://github.com/apache/mynewt-core/pull/2491#issuecomment-781708644
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/hash/hash_kinetis/src/hash_kinetis.c
<details>
```diff
@@ -72,7 +72,7 @@
static int
kinetis_hash_update(struct hash_dev *hash, void *ctx, uint16_t algo,
- const void *inbuf, uint32_t inlen)
+ const void *inbuf, uint32_t inlen)
{
uint32_t i;
uint32_t remain;
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig merged pull request #2491: Fix Kinetis HASH driver with small length buffers
Posted by GitBox <gi...@apache.org>.
utzig merged pull request #2491:
URL: https://github.com/apache/mynewt-core/pull/2491
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org