You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2026/02/23 16:49:40 UTC

[PR] fix(dashboard): fix drop zone vertical shift in tab columns during drag [superset]

kgabryje opened a new pull request, #38192:
URL: https://github.com/apache/superset/pull/38192

   ### SUMMARY
   Drop zones (drop indicators) inside empty columns within tab components were visually shifted up by ~50px (the tab bar height) when dragging charts into them. This was caused by multiple interacting CSS positioning issues:
   
   1. **`.drop-indicator` lacked explicit `top: 0; left: 0`** — It relied on CSS "static position" which can be offset by inherited flex properties (`align-items: center; justify-content: center`)
   2. **Column's `.empty-droptarget` lacked explicit `top: 0; left: 0`** — Same issue, the absolutely positioned droptarget could shift when flex properties leaked from ancestors
   3. **GridContent's `.empty-droptarget` styles leaked into nested components** — The unscoped selector applied `display: flex; align-items: center; justify-content: center; overflow: hidden` to ALL descendant `.empty-droptarget` elements, including those inside Tabs > Rows > Columns. Scoped to direct children (`& > .empty-droptarget`)
   4. **`.dashboard-component-tabs-content` lacked `position: relative`** — Its absolutely positioned droptargets resolved their containing block to the outer Tabs wrapper (which includes the tab bar), instead of the tab content area
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:** Drop zones appear shifted up by ~50px (tab bar height) when dragging charts into empty columns inside tabs
   ![Before](https://github.com/user-attachments/assets/placeholder-before)
   
   ### TESTING INSTRUCTIONS
   1. Open a dashboard in edit mode
   2. Add a Tabs component
   3. Inside the tab, add a Row with two empty Columns
   4. Drag a chart from the right panel toward the empty columns
   5. Verify the blue drop indicator overlay aligns correctly with the "Empty column" content areas (not shifted above them)
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): fix drop zone vertical shift in tab columns during drag [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38192:
URL: https://github.com/apache/superset/pull/38192#issuecomment-3945964379

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): fix drop zone vertical shift in tab columns during drag [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje closed pull request #38192: fix(dashboard): fix drop zone vertical shift in tab columns during drag
URL: https://github.com/apache/superset/pull/38192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): fix drop zone vertical shift in tab columns during drag [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #38192:
URL: https://github.com/apache/superset/pull/38192#issuecomment-3946017220

   Closing in favor of https://github.com/apache/superset/pull/37891


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org