You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/09/06 16:38:45 UTC
[jira] [Commented] (STORM-1032) Add generics to component
configuration methods
[ https://issues.apache.org/jira/browse/STORM-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732399#comment-14732399 ]
ASF GitHub Bot commented on STORM-1032:
---------------------------------------
GitHub user ddebree opened a pull request:
https://github.com/apache/storm/pull/723
[STORM-1032] Add generics to component configuration methods
The getComponentConfiguration methods currently return a simple Map object. In fact they should be returning a Map<String, Object>.
By changing this, it will make it slightly clear what is being returned by the method and potentially pick up some issues at compile time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ddebree/storm configuration_map_generics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/723.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #723
----
commit f55f7a7e57f382b91a700daeeb292580fcf9da7d
Author: ddebree <dd...@gmail.com>
Date: 2015-09-06T14:27:29Z
Add generics to the map returned by component configuration to specify the structure of the configuration
----
> Add generics to component configuration methods
> -----------------------------------------------
>
> Key: STORM-1032
> URL: https://issues.apache.org/jira/browse/STORM-1032
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Dean de Bree
> Assignee: Dean de Bree
> Priority: Minor
>
> The getComponentConfiguration methods currently return a simple Map object. In fact they should be returning a Map<String, Object>.
> By changing this, it will make it slightly clear what is being returned by the method and potentially pick up some issues at compile time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)