You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dstandish (via GitHub)" <gi...@apache.org> on 2026/03/13 21:53:17 UTC
[PR] Move otel tracing helper stuff to _shared [airflow]
dstandish opened a new pull request, #63566:
URL: https://github.com/apache/airflow/pull/63566
This stuff is not needed in airflow core. It is not public interface. And it may at some point be needed by task sdk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move otel tracing helper stuff to _shared [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #63566:
URL: https://github.com/apache/airflow/pull/63566#issuecomment-4067963284
the errors are unrelated; merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move otel tracing helper stuff to _shared [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish merged PR #63566:
URL: https://github.com/apache/airflow/pull/63566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move otel tracing helper stuff to _shared [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #63566:
URL: https://github.com/apache/airflow/pull/63566#discussion_r2940643205
##########
shared/observability/src/airflow_shared/observability/traces/__init__.py:
##########
@@ -30,8 +31,8 @@
from opentelemetry.trace import NonRecordingSpan, SpanContext, TraceFlags
from opentelemetry.trace.propagation.tracecontext import TraceContextTextMapPropagator
-from airflow.configuration import conf
-
+if TYPE_CHECKING:
+ from configparser import ConfigParser
Review Comment:
it's true. and i think we sorta can't import airflow config parser from here right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move otel tracing helper stuff to _shared [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #63566:
URL: https://github.com/apache/airflow/pull/63566#discussion_r2934886080
##########
shared/observability/src/airflow_shared/observability/traces/__init__.py:
##########
@@ -30,8 +31,8 @@
from opentelemetry.trace import NonRecordingSpan, SpanContext, TraceFlags
from opentelemetry.trace.propagation.tracecontext import TraceContextTextMapPropagator
-from airflow.configuration import conf
-
+if TYPE_CHECKING:
+ from configparser import ConfigParser
Review Comment:
This isn't 100% right - we add a few things on top of this like getmodule etc - but it's fine in the case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org