You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/18 14:14:30 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #12694: ARROW-15528: [C++][R][Python] Update ExecPlan bindings

westonpace commented on code in PR #12694:
URL: https://github.com/apache/arrow/pull/12694#discussion_r875951653


##########
r/src/compute-exec.cpp:
##########
@@ -43,6 +43,48 @@ std::shared_ptr<compute::ExecPlan> ExecPlan_create(bool use_threads) {
   return plan;
 }
 
+// [[arrow::export]]
+std::shared_ptr<compute::ExecPlan> ExecPlan_create_with_metadata(

Review Comment:
   It seems rather odd to me that we would need two methods here but it may just be my ignorance of working with R.  Wouldn't it be possible to send an empty value for `metadata` if the user doesn't want to specify it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org