You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4cxx-dev@logging.apache.org by ca...@apache.org on 2007/11/09 03:52:47 UTC

svn commit: r593407 - /logging/log4cxx/trunk/src/test/cpp/rolling/obsoleterollingfileappendertest.cpp

Author: carnold
Date: Thu Nov  8 18:52:46 2007
New Revision: 593407

URL: http://svn.apache.org/viewvc?rev=593407&view=rev
Log:
LOGCXX-52: index miscount resulted in no zero termination for message string in test case

Modified:
    logging/log4cxx/trunk/src/test/cpp/rolling/obsoleterollingfileappendertest.cpp

Modified: logging/log4cxx/trunk/src/test/cpp/rolling/obsoleterollingfileappendertest.cpp
URL: http://svn.apache.org/viewvc/logging/log4cxx/trunk/src/test/cpp/rolling/obsoleterollingfileappendertest.cpp?rev=593407&r1=593406&r2=593407&view=diff
==============================================================================
--- logging/log4cxx/trunk/src/test/cpp/rolling/obsoleterollingfileappendertest.cpp (original)
+++ logging/log4cxx/trunk/src/test/cpp/rolling/obsoleterollingfileappendertest.cpp Thu Nov  8 18:52:46 2007
@@ -65,8 +65,7 @@
   void test1() {
     PropertyConfigurator::configure(File("input/rolling/obsoleteRFA1.properties"));
 
-    char msg[11];
-    strcpy(msg, "Hello---?");
+    char msg[] = { 'H', 'e', 'l', 'l', 'o', '-', '-', '-', '?', 0};
     LoggerPtr logger(Logger::getLogger("org.apache.logj4.ObsoleteRollingFileAppenderTest"));
 
     // Write exactly 10 bytes with each log
@@ -74,11 +73,11 @@
       apr_sleep(100000);
 
       if (i < 10) {
-        msg[9] = (char) ('0' + i);
+        msg[8] = (char) ('0' + i);
         LOG4CXX_DEBUG(logger, msg);
       } else if (i < 100) {
-        msg[8] = (char) ('0' + i / 10);
-        msg[9] = (char) ('0' + i % 10);
+        msg[7] = (char) ('0' + i / 10);
+        msg[8] = (char) ('0' + i % 10);
         LOG4CXX_DEBUG(logger, msg);
       }
     }
@@ -106,8 +105,7 @@
     LoggerPtr root(Logger::getRootLogger());
     root->addAppender(rfa);
 
-    char msg[10];
-    strcpy(msg, "Hello---?");
+    char msg[] = { 'H', 'e', 'l', 'l', 'o', '-', '-', '-', '?', 0};
     LoggerPtr logger(Logger::getLogger("org.apache.logj4.ObsoleteRollingFileAppenderTest"));
 
     // Write exactly 10 bytes with each log