You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2012/11/05 14:52:43 UTC
Review Request: Create a shindig api for developers to see if their gadgets
are rendering in debug mode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/
-----------------------------------------------------------
Review request for shindig.
Description
-------
Useful for gadget developers who are developing in a shindig environment.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core/feature.xml 1404957
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1404957
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/util.js PRE-CREATION
Diff: https://reviews.apache.org/r/7878/diff/
Testing
-------
Thanks,
Dan Dumont
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/#review13198
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On Nov. 6, 2012, 8:21 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7878/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 8:21 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Useful for gadget developers who are developing in a shindig environment.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/feature.xml 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/util.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/authtest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/utiltest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/views/views-init-test.js 1405798
>
> Diff: https://reviews.apache.org/r/7878/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/#review13199
-----------------------------------------------------------
Ship it!
Ship It!
- Stanton Sievers
On Nov. 6, 2012, 8:21 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7878/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 8:21 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Useful for gadget developers who are developing in a shindig environment.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/feature.xml 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/util.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/authtest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/utiltest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/views/views-init-test.js 1405798
>
> Diff: https://reviews.apache.org/r/7878/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/
-----------------------------------------------------------
(Updated Nov. 6, 2012, 8:21 p.m.)
Review request for shindig.
Changes
-------
removed pom.properties file from diff.
Description
-------
Useful for gadget developers who are developing in a shindig environment.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/feature.xml 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/util.js 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/authtest.js 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/utiltest.js 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/views/views-init-test.js 1405798
Diff: https://reviews.apache.org/r/7878/diff/
Testing
-------
Thanks,
Dan Dumont
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Dan Dumont <dd...@us.ibm.com>.
> On Nov. 6, 2012, 8:17 p.m., Stanton Sievers wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/server/target/maven-archiver/pom.properties, lines 1-5
> > <https://reviews.apache.org/r/7878/diff/3/?file=185891#file185891line1>
> >
> > Um, I don't think you want this file.
Not sure how this got in there.... but the other ones aren't in the main diff. Are you seeing them in the version to version diff?
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/#review13165
-----------------------------------------------------------
On Nov. 6, 2012, 7:43 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7878/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 7:43 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Useful for gadget developers who are developing in a shindig environment.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/feature.xml 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/util.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/authtest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/utiltest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/views/views-init-test.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/target/maven-archiver/pom.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7878/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/#review13165
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/feature.xml
<https://reviews.apache.org/r/7878/#comment28333>
You don't want this file anymore, yeah?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/util.js
<https://reviews.apache.org/r/7878/#comment28334>
You don't want this file anymore either, right?
http://svn.apache.org/repos/asf/shindig/trunk/java/server/target/maven-archiver/pom.properties
<https://reviews.apache.org/r/7878/#comment28332>
Um, I don't think you want this file.
- Stanton Sievers
On Nov. 6, 2012, 7:43 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7878/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 7:43 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Useful for gadget developers who are developing in a shindig environment.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/feature.xml 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/util.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/authtest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/utiltest.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/views/views-init-test.js 1405798
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/target/maven-archiver/pom.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7878/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/
-----------------------------------------------------------
(Updated Nov. 6, 2012, 7:43 p.m.)
Review request for shindig.
Changes
-------
Change the namespace.
Description
-------
Useful for gadget developers who are developing in a shindig environment.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/feature.xml 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util/util.js 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/authtest.js 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/utiltest.js 1405798
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/views/views-init-test.js 1405798
http://svn.apache.org/repos/asf/shindig/trunk/java/server/target/maven-archiver/pom.properties PRE-CREATION
Diff: https://reviews.apache.org/r/7878/diff/
Testing
-------
Thanks,
Dan Dumont
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Ryan Baxter <rb...@gmail.com>.
> On Nov. 5, 2012, 2:59 p.m., Stanton Sievers wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/feature.xml, line 30
> > <https://reviews.apache.org/r/7878/diff/2/?file=185409#file185409line30>
> >
> > If this is something we eventually plan to propose for the OpenSocial spec, I'd rather not have it in a "shindig.*" namespace.
>
> Dan Dumont wrote:
> I didn't want to have to visit that yet. I think once it does move to the spec we can deprecate the shindig.* api and point the impl to the official spec namespace.
Yes I already have a proposal started for 3.0 [1]. I agree with Stanton that it should not be in the shindig namespace right now, even if it not in the spec. It will be used by gadgets so i makes sense to be in the gadgets namespace. I don't see any harm in it being there.
1. http://docs.opensocial.org/display/OSD/Serviceability+Improvements+For+Gadgets
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/#review13094
-----------------------------------------------------------
On Nov. 5, 2012, 1:55 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7878/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2012, 1:55 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Useful for gadget developers who are developing in a shindig environment.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core/feature.xml 1404957
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1404957
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/util.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7878/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Dan Dumont <dd...@us.ibm.com>.
> On Nov. 5, 2012, 2:59 p.m., Stanton Sievers wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/feature.xml, line 30
> > <https://reviews.apache.org/r/7878/diff/2/?file=185409#file185409line30>
> >
> > If this is something we eventually plan to propose for the OpenSocial spec, I'd rather not have it in a "shindig.*" namespace.
I didn't want to have to visit that yet. I think once it does move to the spec we can deprecate the shindig.* api and point the impl to the official spec namespace.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/#review13094
-----------------------------------------------------------
On Nov. 5, 2012, 1:55 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7878/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2012, 1:55 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Useful for gadget developers who are developing in a shindig environment.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core/feature.xml 1404957
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1404957
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/util.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7878/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/#review13094
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/feature.xml
<https://reviews.apache.org/r/7878/#comment28223>
If this is something we eventually plan to propose for the OpenSocial spec, I'd rather not have it in a "shindig.*" namespace.
- Stanton Sievers
On Nov. 5, 2012, 1:55 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7878/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2012, 1:55 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Useful for gadget developers who are developing in a shindig environment.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core/feature.xml 1404957
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1404957
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/util.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7878/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Create a shindig api for developers to see if their
gadgets are rendering in debug mode
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/
-----------------------------------------------------------
(Updated Nov. 5, 2012, 1:55 p.m.)
Review request for shindig.
Description
-------
Useful for gadget developers who are developing in a shindig environment.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core/feature.xml 1404957
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1404957
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.core.util/util.js PRE-CREATION
Diff: https://reviews.apache.org/r/7878/diff/
Testing
-------
Thanks,
Dan Dumont