You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Jonathan Chang (Created) (JIRA)" <ji...@apache.org> on 2011/10/31 19:19:32 UTC
[jira] [Created] (HIVE-2536) Support scientific notation for Double
literals
Support scientific notation for Double literals
-----------------------------------------------
Key: HIVE-2536
URL: https://issues.apache.org/jira/browse/HIVE-2536
Project: Hive
Issue Type: Bug
Reporter: Jonathan Chang
Assignee: Jonathan Chang
Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140443#comment-13140443 ]
Phabricator commented on HIVE-2536:
-----------------------------------
jonchang has commented on the revision "[jira] [HIVE-2536] Support scientific notation for Double literals".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g:2382 I totally don't know why, but not having this OR clause here (and using the version on the left) will cause all scientific notation to break. ANTLR bug perhaps?
REVISION DETAIL
https://reviews.facebook.net/D129
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140995#comment-13140995 ]
Phabricator commented on HIVE-2536:
-----------------------------------
jonchang has committed the revision "[jira] [HIVE-2536] Support scientific notation for Double literals".
REVISION DETAIL
https://reviews.facebook.net/D129
COMMIT
https://reviews.facebook.net/rHIVE1195830
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Fix For: 0.9.0
>
> Attachments: D129.1.patch, D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141052#comment-13141052 ]
Hudson commented on HIVE-2536:
------------------------------
Integrated in Hive-trunk-h0.21 #1049 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1049/])
HIVE-2536. Support scientific notation for Double literals
(Jonathan Chang via jvs)
Summary:
HIVE-2536
Of the form 1.0e10.
Test Plan: EMPTY
Reviewers: DUMMY_REVIEWER, jsichi
Reviewed By: jsichi
CC: JIRA, jonchang, jsichi
Differential Revision: 129
jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195830
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
* /hive/trunk/ql/src/test/queries/clientpositive/literal_double.q
* /hive/trunk/ql/src/test/results/clientpositive/literal_double.q.out
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Fix For: 0.9.0
>
> Attachments: D129.1.patch, D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140956#comment-13140956 ]
Phabricator commented on HIVE-2536:
-----------------------------------
jonchang has committed the revision "[jira] [HIVE-2536] Support scientific notation for Double literals".
REVISION DETAIL
https://reviews.facebook.net/D129
COMMIT
https://reviews.facebook.net/rHIVE1195830
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Fix For: 0.9.0
>
> Attachments: D129.1.patch, D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2536) Support scientific notation for Double
literals
Posted by "Jonathan Chang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Chang updated HIVE-2536:
---------------------------------
Attachment: D129.1.patch
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: D129.1.patch, D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140954#comment-13140954 ]
Phabricator commented on HIVE-2536:
-----------------------------------
jonchang has committed the revision "[jira] [HIVE-2536] Support scientific notation for Double literals".
REVISION DETAIL
https://reviews.facebook.net/D129
COMMIT
https://reviews.facebook.net/rHIVE1195830
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Fix For: 0.9.0
>
> Attachments: D129.1.patch, D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140442#comment-13140442 ]
Phabricator commented on HIVE-2536:
-----------------------------------
jonchang has commented on the revision "[jira] [HIVE-2536] Support scientific notation for Double literals".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g:2382 I totally don't know why, but not having this OR clause here (and using the version on the left) will cause all scientific notation to break. ANTLR bug perhaps?
REVISION DETAIL
https://reviews.facebook.net/D129
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HIVE-2536) Support scientific notation for
Double literals
Posted by "John Sichi (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi resolved HIVE-2536.
------------------------------
Resolution: Fixed
Fix Version/s: 0.9.0
Hadoop Flags: Reviewed
Committed to trunk. Thanks Jonathan!
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Fix For: 0.9.0
>
> Attachments: D129.1.patch, D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "John Sichi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140517#comment-13140517 ]
John Sichi commented on HIVE-2536:
----------------------------------
+1, will commit when tests pass.
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140512#comment-13140512 ]
Phabricator commented on HIVE-2536:
-----------------------------------
jsichi has accepted the revision "[jira] [HIVE-2536] Support scientific notation for Double literals".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g:2382 Interesting. Before, it was interpreting
select 1.0e3
the same as
select 1.0 e3
which fits the pattern
select 1.0 mycolumnaliaswhichendswithadigi7
Dunno why introducing the choice into the grammar gives the fragment precedence over the column aliasing rule, but since we need it anyway...shipit.
REVISION DETAIL
https://reviews.facebook.net/D129
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140511#comment-13140511 ]
Phabricator commented on HIVE-2536:
-----------------------------------
jsichi has accepted the revision "[jira] [HIVE-2536] Support scientific notation for Double literals".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g:2382 Interesting. Before, it was interpreting
select 1.0e3
the same as
select 1.0 e3
which fits the pattern
select 1.0 mycolumnaliaswhichendswithadigi7
Dunno why introducing the choice into the grammar gives the fragment precedence over the column aliasing rule, but since we need it anyway...shipit.
REVISION DETAIL
https://reviews.facebook.net/D129
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2536) Support scientific notation for Double
literals
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2536:
------------------------------
Attachment: D129.1.patch
jonchang requested code review of "[jira] [HIVE-2536] Support scientific notation for Double literals".
Reviewers: DUMMY_REVIEWER
HIVE-2536
Of the form 1.0e10.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D129
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
ql/src/test/queries/clientpositive/literal_double.q
ql/src/test/results/clientpositive/literal_double.q.out
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/273/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2536) Support scientific notation for
Double literals
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140510#comment-13140510 ]
Phabricator commented on HIVE-2536:
-----------------------------------
jsichi has accepted the revision "[jira] [HIVE-2536] Support scientific notation for Double literals".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g:2382 Interesting. Before, it was interpreting
select 1.0e3
the same as
select 1.0 e3
which fits the pattern
select 1.0 mycolumnaliaswhichendswithadigi7
Dunno why introducing the choice into the grammar gives the fragment precedence over the column aliasing rule, but since we need it anyway...shipit.
REVISION DETAIL
https://reviews.facebook.net/D129
> Support scientific notation for Double literals
> -----------------------------------------------
>
> Key: HIVE-2536
> URL: https://issues.apache.org/jira/browse/HIVE-2536
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: D129.1.patch, D129.1.patch
>
>
> Of the form 1.0e10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira