You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefania (JIRA)" <ji...@apache.org> on 2016/12/20 03:56:58 UTC
[jira] [Comment Edited] (CASSANDRA-13050) ReadCommand.CheckForAbort
not monitoring CQL rows for range queries
[ https://issues.apache.org/jira/browse/CASSANDRA-13050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763113#comment-15763113 ]
Stefania edited comment on CASSANDRA-13050 at 12/20/16 3:56 AM:
----------------------------------------------------------------
I've fixed a few problems with the previous patch and I've multiplexed slow and aborted query tests 4 times with no failures:
* http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/90
* http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/91
* http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/92
* http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/93
Proposed patch (it applies without conflicts to all branches):
||3.11||3.X||trunk||
|[patch|https://github.com/stef1927/cassandra/tree/13050-3.11]|[patch|https://github.com/stef1927/cassandra/tree/13050-3.X]|[patch|https://github.com/stef1927/cassandra/tree/13050]|
|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.11-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.X-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-testall/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.11-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.X-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-dtest/]|
Dtests must run with this modified [branch|https://github.com/riptano/cassandra-dtest/compare/master...stef1927:13050] or some slow or aborted query tests may time out since we are now applying the test delay for every CQL row. Pull request for tests is [here|https://github.com/riptano/cassandra-dtest/pull/1413].
was (Author: stefania):
I've fixed a few problems with the previous patch and I've multiplexed slow and aborted query tests 4 times with no failures:
* http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/90
* http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/91
* http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/92
* http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/93
Proposed patch (it applies without conflicts to all branches):
||3.11||3.X||trunk||
|[patch|https://github.com/stef1927/cassandra/tree/13050-3.11]|[patch|https://github.com/stef1927/cassandra/tree/13050-3.X]|[patch|https://github.com/stef1927/cassandra/tree/13050]|
|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.11-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.X-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-testall/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.11-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.X-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-dtest/]|
Dtests must run with modified dtest [branch|https://github.com/riptano/cassandra-dtest/compare/master...stef1927:13050] or else some slow or aborted query tests may time out since we are now applying the test delay for every CQL row.
> ReadCommand.CheckForAbort not monitoring CQL rows for range queries
> -------------------------------------------------------------------
>
> Key: CASSANDRA-13050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13050
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
> Reporter: Stefania
> Assignee: Stefania
> Fix For: 3.x
>
>
> -If I understood the iterator transformations introduced by CASSANDRA-9975 correctly,- [ReadCommand.CheckForAbort|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/db/ReadCommand.java#L541] should apply itself before returning a partition. At the moment it is applied to row iterators for single command partitions, but for range queries -I think- it only monitors the query progress when a new partition is iterated, not when a new row is iterated. So for large partitions, we may fail to log a query as slow, or fail to abort it if the RPC timeout is exceeded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)