Re: [PR] kyuubi-beeline auto constructs JDBC URL from kyuubi-defaults.conf [kyuubi]

["zhaohehuhu (via GitHub)" <gi...@apache.org>]

zhaohehuhu commented on code in PR #6339:
URL: https://github.com/apache/kyuubi/pull/6339#discussion_r1596376060


##########
kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/BeeLine.java:
##########
@@ -1012,6 +1010,14 @@ private String getDefaultConnectionUrl(CommandLine cl) throws BeelineConfFilePar
       userConnectionProperties = userHS2ConnFileParser.getConnectionProperties();
     }
 
+    if (kyuubiConfFileParser.configExists()) {
+      // get the connection properties from user specific config file
+      Properties properties = kyuubiConfFileParser.getConnectionProperties();
+      for (String key : properties.stringPropertyNames()) {
+        userConnectionProperties.setProperty(key, properties.getProperty(key));

Review Comment:
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org