You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sg...@apache.org on 2015/11/10 14:46:02 UTC
cordova-plugin-inappbrowser git commit: CB-9799 Fixed javaDoc
errors.. This closes #119
Repository: cordova-plugin-inappbrowser
Updated Branches:
refs/heads/master 32743e0eb -> 1afd42aab
CB-9799 Fixed javaDoc errors.. This closes #119
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/1afd42aa
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/1afd42aa
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/1afd42aa
Branch: refs/heads/master
Commit: 1afd42aabbe51c949affb2d5f85e73858700b499
Parents: 32743e0
Author: Paul Weber <pa...@iwa-tech.com>
Authored: Wed Oct 14 19:22:14 2015 +0200
Committer: sgrebnov <v-...@microsoft.com>
Committed: Tue Nov 10 16:45:00 2015 +0300
----------------------------------------------------------------------
src/android/InAppBrowser.java | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/1afd42aa/src/android/InAppBrowser.java
----------------------------------------------------------------------
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index 3ee1853..6043745 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -72,7 +72,6 @@ public class InAppBrowser extends CordovaPlugin {
protected static final String LOG_TAG = "InAppBrowser";
private static final String SELF = "_self";
private static final String SYSTEM = "_system";
- // private static final String BLANK = "_blank";
private static final String EXIT_EVENT = "exit";
private static final String LOCATION = "location";
private static final String ZOOM = "zoom";
@@ -98,10 +97,10 @@ public class InAppBrowser extends CordovaPlugin {
/**
* Executes the request and returns PluginResult.
*
- * @param action The action to execute.
- * @param args JSONArry of arguments for the plugin.
- * @param callbackId The callback id used when calling back into JavaScript.
- * @return A PluginResult object with a status and message.
+ * @param action the action to execute.
+ * @param args JSONArry of arguments for the plugin.
+ * @param callbackContext the callbackContext used when calling back into JavaScript.
+ * @return A PluginResult object with a status and message.
*/
public boolean execute(String action, CordovaArgs args, final CallbackContext callbackContext) throws JSONException {
if (action.equals("open")) {
@@ -332,9 +331,8 @@ public class InAppBrowser extends CordovaPlugin {
/**
* Display a new browser with the specified URL.
*
- * @param url The url to load.
- * @param usePhoneGap Load url in PhoneGap webview
- * @return "" if ok, or error message.
+ * @param url the url to load.
+ * @return "" if ok, or error message.
*/
public String openExternal(String url) {
try {
@@ -462,8 +460,8 @@ public class InAppBrowser extends CordovaPlugin {
/**
* Display a new browser with the specified URL.
*
- * @param url The url to load.
- * @param jsonObject
+ * @param url the url to load.
+ * @param features jsonObject
*/
public String showWebPage(final String url, HashMap<String, Boolean> features) {
// Determine if we should hide the location bar.
@@ -746,8 +744,8 @@ public class InAppBrowser extends CordovaPlugin {
/**
* Constructor.
*
- * @param mContext
- * @param edittext
+ * @param webView
+ * @param mEditText
*/
public InAppBrowserClient(CordovaWebView webView, EditText mEditText) {
this.webView = webView;
@@ -868,3 +866,4 @@ public class InAppBrowser extends CordovaPlugin {
}
}
}
+
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org