You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/27 08:54:58 UTC
[GitHub] [airflow] chuancyzhang opened a new pull request #17253: add encoding config in FtpHook
chuancyzhang opened a new pull request #17253:
URL: https://github.com/apache/airflow/pull/17253
The default ftplib package in FTP Hook is latin-1 encoding. If you encounter Chinese or other non-English languages, you will encounter garbled characters if you use list_directory and other methods, so you can add a configuration item to change the encoding in FTP Hook.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on a change in pull request #17253: add encoding config in FtpHook
Posted by GitBox <gi...@apache.org>.
subkanthi commented on a change in pull request #17253:
URL: https://github.com/apache/airflow/pull/17253#discussion_r677379966
##########
File path: airflow/providers/ftp/hooks/ftp.py
##########
@@ -60,8 +60,10 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params = self.get_connection(self.ftp_conn_id)
pasv = params.extra_dejson.get("passive", True)
+ encoding = params.extra_dejson.get("encoding", "latin-1")
Review comment:
is there a reason this defaults to latin-1 and not utf-8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17253: add encoding config in FtpHook
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17253:
URL: https://github.com/apache/airflow/pull/17253#issuecomment-887335498
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chuancyzhang commented on a change in pull request #17253: add encoding config in FtpHook
Posted by GitBox <gi...@apache.org>.
chuancyzhang commented on a change in pull request #17253:
URL: https://github.com/apache/airflow/pull/17253#discussion_r677906416
##########
File path: airflow/providers/ftp/hooks/ftp.py
##########
@@ -60,8 +60,10 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params = self.get_connection(self.ftp_conn_id)
pasv = params.extra_dejson.get("passive", True)
+ encoding = params.extra_dejson.get("encoding", "latin-1")
Review comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chuancyzhang commented on a change in pull request #17253: add encoding config in FtpHook
Posted by GitBox <gi...@apache.org>.
chuancyzhang commented on a change in pull request #17253:
URL: https://github.com/apache/airflow/pull/17253#discussion_r677935796
##########
File path: airflow/providers/ftp/hooks/ftp.py
##########
@@ -60,8 +60,10 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params = self.get_connection(self.ftp_conn_id)
pasv = params.extra_dejson.get("passive", True)
+ encoding = params.extra_dejson.get("encoding", "latin-1")
Review comment:
conn.encoding is default config. I used if to judge whether encoding is in extra_dejson, not try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #17253: add encoding config in FtpHook
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #17253:
URL: https://github.com/apache/airflow/pull/17253#discussion_r677930962
##########
File path: airflow/providers/ftp/hooks/ftp.py
##########
@@ -60,8 +60,10 @@ def get_conn(self) -> ftplib.FTP:
if self.conn is None:
params = self.get_connection(self.ftp_conn_id)
pasv = params.extra_dejson.get("passive", True)
+ encoding = params.extra_dejson.get("encoding", "latin-1")
Review comment:
What is the current behaviour? I am not familiar with FTP, is “server default” a thing? If there is, we should probably do something like
```python
try:
self.conn.encoding = params.extra_dejson["encoding"]
except KeyError:
pass
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17253: add encoding config in FtpHook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17253:
URL: https://github.com/apache/airflow/pull/17253#issuecomment-917507218
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #17253: add encoding config in FtpHook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #17253:
URL: https://github.com/apache/airflow/pull/17253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org