[GitHub] [incubator-livy] runzhiwang commented on a change in pull request #274: [LIVY-721][SERVER] Distributed session id generation

[GitBox <gi...@apache.org>]

runzhiwang commented on a change in pull request #274: [LIVY-721][SERVER] Distributed session id generation
URL: https://github.com/apache/incubator-livy/pull/274#discussion_r366666905
 
 

 ##########
 File path: server/src/main/scala/org/apache/livy/sessions/SessionIdGenerator.scala
 ##########
 @@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.sessions
+
+/**
+  * Interface of session id generator.
+  */
+abstract class SessionIdGenerator {
+  /**
+    * Get next session id, then increase next session id and save it in store.
+    */
+  def getNextSessionId(): Int
+
+  /**
+    * recover next session id from store.
+    */
+  def recover(): Unit
 
 Review comment:
   @yiheng Good point.  Actually  it does not need `recover ` any more. For `LocalSessionIdGenerator`, it store session id in memory, so can not recover. For `DistributedSessionIdGenerator`,  it will get session id from store every time `getNextSessionId`, so it does not need recover when restart. I will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services