[GitHub] merlimat commented on a change in pull request #3650: Use less aggressive JVM memory settings in default config file

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #3650: Use less aggressive JVM memory settings in default config file
URL: https://github.com/apache/pulsar/pull/3650#discussion_r259193056
 
 

 ##########
 File path: conf/bkenv.sh
 ##########
 @@ -33,10 +33,13 @@ BOOKIE_CONF=${BOOKIE_CONF:-"$BK_HOME/conf/bookkeeper.conf"}
 # BOOKIE_LOG_DIR=
 
 # Memory size options
-BOOKIE_MEM=" -Xms2g -Xmx2g -XX:MaxDirectMemorySize=2g"
+BOOKIE_MEM=" -Xmx2g -XX:MaxDirectMemorySize=2g -XX:+ExitOnOutOfMemoryError"
 
 # Garbage collection options
-BOOKIE_GC=" -XX:+UseG1GC -XX:MaxGCPauseMillis=10 -XX:+ParallelRefProcEnabled -XX:+UnlockExperimentalVMOptions -XX:+AggressiveOpts -XX:+DoEscapeAnalysis -XX:ParallelGCThreads=32 -XX:ConcGCThreads=32 -XX:G1NewSizePercent=50 -XX:+DisableExplicitGC -XX:-ResizePLAB"
+BOOKIE_GC=" -XX:+UseG1GC"
 
 Review comment:
   I don't think this is a "breaking" change in the sense that it will not make anything that was work to stop working. 
   
   Sure, it's a different setting and that should be documented, but the purpose of this change is to change the "default" setting, because it's not ideal to be used as "default", rather than allow the users to change the default (which is already possible). 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services