You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/21 06:54:12 UTC
[GitHub] [doris] xinyiZzz commented on a diff in pull request #12716: [Enhancement](load) Refine the load channel flush policy on mem limit (WIP)
xinyiZzz commented on code in PR #12716:
URL: https://github.com/apache/doris/pull/12716#discussion_r976107494
##########
be/src/runtime/load_channel_mgr.cpp:
##########
@@ -126,6 +110,15 @@ Status LoadChannelMgr::open(const PTabletWriterOpenRequest& params) {
return Status::OK();
}
+void LoadChannelMgr::_pending_if_hard_limit_exceeded() {
+ std::unique_lock<std::mutex> l(_lock);
+ while (_hard_limit_reached) {
+ LOG(INFO) << "Reached the load channel manager mem limit " << _mem_tracker->limit()
Review Comment:
`LOG(INFO) ` may print frequently, consider => `VLOG_NOTICE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org