You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/19 11:54:50 UTC
[GitHub] [beam] bullet03 opened a new pull request, #17390: [BEAM-14322] [Website] update carousel cards
bullet03 opened a new pull request, #17390:
URL: https://github.com/apache/beam/pull/17390
[BEAM-14322]
- update structure of quote cards
- update scss and html styles
- change cards content and images
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov commented on pull request #17390: [BEAM-14322] [Website] update carousel cards
Posted by GitBox <gi...@apache.org>.
nausharipov commented on PR #17390:
URL: https://github.com/apache/beam/pull/17390#issuecomment-1102917895
LGTM. We only need merge the change from #17205 that removes the unused const swiper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17390: [BEAM-14322] [Website] update carousel cards
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17390:
URL: https://github.com/apache/beam/pull/17390#issuecomment-1102549290
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on a diff in pull request #17390: [BEAM-14322] [Website] update carousel cards
Posted by GitBox <gi...@apache.org>.
bullet03 commented on code in PR #17390:
URL: https://github.com/apache/beam/pull/17390#discussion_r854380398
##########
website/www/site/assets/scss/_quotes.scss:
##########
@@ -107,7 +106,9 @@
span {
padding-right: 10px;
}
+
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17390: [BEAM-14322] [Website] update carousel cards
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17390:
URL: https://github.com/apache/beam/pull/17390#issuecomment-1102549296
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #17390: [BEAM-14322] [Website] update carousel cards
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #17390:
URL: https://github.com/apache/beam/pull/17390#issuecomment-1104704355
Changes from this PR are already in https://github.com/apache/beam/pull/17205. There is no need in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #17390: [BEAM-14322] [Website] update carousel cards
Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #17390:
URL: https://github.com/apache/beam/pull/17390#issuecomment-1102549959
R: @nausharipov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov commented on a diff in pull request #17390: [BEAM-14322] [Website] update carousel cards
Posted by GitBox <gi...@apache.org>.
nausharipov commented on code in PR #17390:
URL: https://github.com/apache/beam/pull/17390#discussion_r854330634
##########
website/www/site/assets/scss/_quotes.scss:
##########
@@ -107,7 +106,9 @@
span {
padding-right: 10px;
}
+
Review Comment:
make sure to format every file you work with. It helps to increase code consistency and to avoid future merge conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17390: [BEAM-14322] [Website] update carousel cards
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17390:
URL: https://github.com/apache/beam/pull/17390#issuecomment-1102549289
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 closed pull request #17390: [BEAM-14322] [Website] update carousel cards
Posted by GitBox <gi...@apache.org>.
bullet03 closed pull request #17390: [BEAM-14322] [Website] update carousel cards
URL: https://github.com/apache/beam/pull/17390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org