You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/20 16:16:24 UTC
[GitHub] [pulsar] zzccctv opened a new pull request, #19301: [fix][client]The format of the example in the auth-params description is incorrect
zzccctv opened a new pull request, #19301:
URL: https://github.com/apache/pulsar/pull/19301
Motivation
The format of the example in the auth-params description is incorrect
Modifications
Add quotation marks
Documentation
- [ ] doc
- [ ] doc-required
- [ ] doc-not-needed
- [ ] doc-complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19301: [fix][client]The format of the example in the auth-params description is incorrect
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19301:
URL: https://github.com/apache/pulsar/pull/19301#issuecomment-1398618213
@zzccctv Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #19301: [fix][cli]The format of the example in the auth-params description is incorrect
Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #19301:
URL: https://github.com/apache/pulsar/pull/19301#issuecomment-1407267841
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #19301: [fix][cli] The format of the example in the auth-params description is incorrect
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #19301:
URL: https://github.com/apache/pulsar/pull/19301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #19301: [fix][cli] The format of the example in the auth-params description is incorrect
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #19301:
URL: https://github.com/apache/pulsar/pull/19301#issuecomment-1407293525
Merging...
Thanks for your contribution @zzccctv!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19301: [fix][cli] The format of the example in the auth-params description is incorrect
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19301:
URL: https://github.com/apache/pulsar/pull/19301#issuecomment-1407282543
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19301](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a79ebd) into [master](https://codecov.io/gh/apache/pulsar/commit/457a0d5ec6a79ce957ea2fa30c4859eb9a87222e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (457a0d5) will **decrease** coverage by `31.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19301 +/- ##
=============================================
- Coverage 63.54% 32.30% -31.24%
- Complexity 3615 6141 +2526
=============================================
Files 1895 1644 -251
Lines 137475 123692 -13783
Branches 15091 13487 -1604
=============================================
- Hits 87355 39959 -47396
- Misses 42240 77840 +35600
+ Partials 7880 5893 -1987
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.91% <ø> (+0.73%)` | :arrow_up: |
| systests | `25.53% <ø> (-0.33%)` | :arrow_down: |
| unittests | `16.83% <ø> (-44.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/pulsar/admin/cli/PulsarAdminTool.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9QdWxzYXJBZG1pblRvb2wuamF2YQ==) | `0.00% <ø> (-86.85%)` | :arrow_down: |
| [...org/apache/pulsar/client/cli/PulsarClientTool.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9jbGkvUHVsc2FyQ2xpZW50VG9vbC5qYXZh) | `55.39% <ø> (-10.80%)` | :arrow_down: |
| [.../main/java/org/apache/pulsar/io/core/KeyValue.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWlvL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9pby9jb3JlL0tleVZhbHVlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ain/java/org/apache/pulsar/broker/rest/Topics.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9yZXN0L1RvcGljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pulsar/proxy/stats/TopicStats.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXByb3h5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvcHJveHkvc3RhdHMvVG9waWNTdGF0cy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...n/java/org/apache/pulsar/io/hdfs2/Compression.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWlvL2hkZnMyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvaW8vaGRmczIvQ29tcHJlc3Npb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...n/java/org/apache/pulsar/io/hdfs3/Compression.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWlvL2hkZnMzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvaW8vaGRmczMvQ29tcHJlc3Npb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pulsar/broker/admin/v1/Brokers.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9Ccm9rZXJzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/bookkeeper/mledger/ScanOutcome.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9TY2FuT3V0Y29tZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pulsar/broker/admin/v1/Clusters.java](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9DbHVzdGVycy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1350 more](https://codecov.io/gh/apache/pulsar/pull/19301?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org