[GitHub] [accumulo] dlmarion commented on a diff in pull request #3106: Remove deprecated properties

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #3106:
URL: https://github.com/apache/accumulo/pull/3106#discussion_r1039542689


##########
server/base/src/test/java/org/apache/accumulo/server/master/balancer/TableLoadBalancerTest.java:
##########
@@ -146,10 +146,6 @@ public void test() {
     TableConfiguration conf = createMock(TableConfiguration.class);
     // Eclipse might show @SuppressWarnings("removal") as unnecessary.

Review Comment:
   Can we get rid of these comments also?



##########
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java:
##########
@@ -146,15 +146,6 @@ public void execute(String[] args) throws Exception {
         }
       }
 
-      // Remove the tracers, we don't use them anymore.
-      @SuppressWarnings("deprecation")
-      String path = siteConf.get(Property.TRACE_ZK_PATH);
-      try {
-        zapDirectory(zoo, path, opts);

Review Comment:
   Do we need to remove this as a final step in the upgrade from 2.1 -> 3.0? I didn't look to see if this is already done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org